Shindig
  1. Shindig
  2. SHINDIG-1727

gadgets.selection.getSelection() does not return current selection on initial loading of gadget

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Javascript
    • Labels:
      None
    • Environment:
      Windows 7

      Description

      1) Load first gadget
      2) Set a selection in the first gadget using gadgets.selection.setSelection
      3) Load second gadget
      4) do a gadgets.selection.getSelection in second gadget
      Expected: gadgets.selection.getSelection returns selection made in first gadget
      Actual: gadgets.selection.getSelection returns undefined

      1. shindig.patch
        10 kB
        Dan Dumont

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4310/
        -----------------------------------------------------------

        Review request for shindig.

        Summary
        -------

        Updated sample gadgets.
        Added a dummy listener to the selection queue so that a gadget will always watch selection.
        Selection registration now returns the current selection so that gadgets can prime their selection cache.

        This addresses bug SHINDIG-1727.
        https://issues.apache.org/jira/browse/SHINDIG-1727

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267

        Diff: https://reviews.apache.org/r/4310/diff

        Testing
        -------

        Updated and ran unit tests.
        Updated sample gadgets, ran sample gadgets in the sample container.

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ ----------------------------------------------------------- Review request for shindig. Summary ------- Updated sample gadgets. Added a dummy listener to the selection queue so that a gadget will always watch selection. Selection registration now returns the current selection so that gadgets can prime their selection cache. This addresses bug SHINDIG-1727 . https://issues.apache.org/jira/browse/SHINDIG-1727 Diffs http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267 Diff: https://reviews.apache.org/r/4310/diff Testing ------- Updated and ran unit tests. Updated sample gadgets, ran sample gadgets in the sample container. Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4310/
        -----------------------------------------------------------

        (Updated 2012-03-13 18:36:35.048131)

        Review request for shindig.

        Changes
        -------

        Changed tabs to spaces.

        Summary
        -------

        Updated sample gadgets.
        Added a dummy listener to the selection queue so that a gadget will always watch selection.
        Selection registration now returns the current selection so that gadgets can prime their selection cache.

        This addresses bug SHINDIG-1727.
        https://issues.apache.org/jira/browse/SHINDIG-1727

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267

        Diff: https://reviews.apache.org/r/4310/diff

        Testing
        -------

        Updated and ran unit tests.
        Updated sample gadgets, ran sample gadgets in the sample container.

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ ----------------------------------------------------------- (Updated 2012-03-13 18:36:35.048131) Review request for shindig. Changes ------- Changed tabs to spaces. Summary ------- Updated sample gadgets. Added a dummy listener to the selection queue so that a gadget will always watch selection. Selection registration now returns the current selection so that gadgets can prime their selection cache. This addresses bug SHINDIG-1727 . https://issues.apache.org/jira/browse/SHINDIG-1727 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267 Diff: https://reviews.apache.org/r/4310/diff Testing ------- Updated and ran unit tests. Updated sample gadgets, ran sample gadgets in the sample container. Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4310/#review5892
        -----------------------------------------------------------

        LGTM, just the one question inline.

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
        <https://reviews.apache.org/r/4310/#comment12849>

        Before when this wasn't being returned, what did that affect? Did that only mean the selection wasn't available in the callback to the register rpc call?

        • Stanton

        On 2012-03-13 18:36:35, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4310/

        -----------------------------------------------------------

        (Updated 2012-03-13 18:36:35)

        Review request for shindig.

        Summary

        -------

        Updated sample gadgets.

        Added a dummy listener to the selection queue so that a gadget will always watch selection.

        Selection registration now returns the current selection so that gadgets can prime their selection cache.

        This addresses bug SHINDIG-1727.

        https://issues.apache.org/jira/browse/SHINDIG-1727

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267

        Diff: https://reviews.apache.org/r/4310/diff

        Testing

        -------

        Updated and ran unit tests.

        Updated sample gadgets, ran sample gadgets in the sample container.

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5892 ----------------------------------------------------------- LGTM, just the one question inline. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js < https://reviews.apache.org/r/4310/#comment12849 > Before when this wasn't being returned, what did that affect? Did that only mean the selection wasn't available in the callback to the register rpc call? Stanton On 2012-03-13 18:36:35, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ ----------------------------------------------------------- (Updated 2012-03-13 18:36:35) Review request for shindig. Summary ------- Updated sample gadgets. Added a dummy listener to the selection queue so that a gadget will always watch selection. Selection registration now returns the current selection so that gadgets can prime their selection cache. This addresses bug SHINDIG-1727 . https://issues.apache.org/jira/browse/SHINDIG-1727 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267 Diff: https://reviews.apache.org/r/4310/diff Testing ------- Updated and ran unit tests. Updated sample gadgets, ran sample gadgets in the sample container. Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4310/#review5896
        -----------------------------------------------------------

        Ship it!

        LGTM echo Stanton's question

        • Ryan

        On 2012-03-13 18:36:35, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4310/

        -----------------------------------------------------------

        (Updated 2012-03-13 18:36:35)

        Review request for shindig.

        Summary

        -------

        Updated sample gadgets.

        Added a dummy listener to the selection queue so that a gadget will always watch selection.

        Selection registration now returns the current selection so that gadgets can prime their selection cache.

        This addresses bug SHINDIG-1727.

        https://issues.apache.org/jira/browse/SHINDIG-1727

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267

        Diff: https://reviews.apache.org/r/4310/diff

        Testing

        -------

        Updated and ran unit tests.

        Updated sample gadgets, ran sample gadgets in the sample container.

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5896 ----------------------------------------------------------- Ship it! LGTM echo Stanton's question Ryan On 2012-03-13 18:36:35, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ ----------------------------------------------------------- (Updated 2012-03-13 18:36:35) Review request for shindig. Summary ------- Updated sample gadgets. Added a dummy listener to the selection queue so that a gadget will always watch selection. Selection registration now returns the current selection so that gadgets can prime their selection cache. This addresses bug SHINDIG-1727 . https://issues.apache.org/jira/browse/SHINDIG-1727 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267 Diff: https://reviews.apache.org/r/4310/diff Testing ------- Updated and ran unit tests. Updated sample gadgets, ran sample gadgets in the sample container. Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-03-13 20:28:04, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js, line 74

        > <https://reviews.apache.org/r/4310/diff/2/?file=91746#file91746line74>

        >

        > Before when this wasn't being returned, what did that affect? Did that only mean the selection wasn't available in the callback to the register rpc call?

        I added the callback and the return so that initial selection would be published to the gadget without calling a selection changed listener (cause it didn't change, the gadget just didn't have it yet).

        • Dan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4310/#review5892
        -----------------------------------------------------------

        On 2012-03-13 18:36:35, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4310/

        -----------------------------------------------------------

        (Updated 2012-03-13 18:36:35)

        Review request for shindig.

        Summary

        -------

        Updated sample gadgets.

        Added a dummy listener to the selection queue so that a gadget will always watch selection.

        Selection registration now returns the current selection so that gadgets can prime their selection cache.

        This addresses bug SHINDIG-1727.

        https://issues.apache.org/jira/browse/SHINDIG-1727

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267

        Diff: https://reviews.apache.org/r/4310/diff

        Testing

        -------

        Updated and ran unit tests.

        Updated sample gadgets, ran sample gadgets in the sample container.

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-03-13 20:28:04, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js , line 74 > < https://reviews.apache.org/r/4310/diff/2/?file=91746#file91746line74 > > > Before when this wasn't being returned, what did that affect? Did that only mean the selection wasn't available in the callback to the register rpc call? I added the callback and the return so that initial selection would be published to the gadget without calling a selection changed listener (cause it didn't change, the gadget just didn't have it yet). Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5892 ----------------------------------------------------------- On 2012-03-13 18:36:35, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ ----------------------------------------------------------- (Updated 2012-03-13 18:36:35) Review request for shindig. Summary ------- Updated sample gadgets. Added a dummy listener to the selection queue so that a gadget will always watch selection. Selection registration now returns the current selection so that gadgets can prime their selection cache. This addresses bug SHINDIG-1727 . https://issues.apache.org/jira/browse/SHINDIG-1727 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267 Diff: https://reviews.apache.org/r/4310/diff Testing ------- Updated and ran unit tests. Updated sample gadgets, ran sample gadgets in the sample container. Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4310/#review5935
        -----------------------------------------------------------

        Ship it!

        LGTM

        • Stanton

        On 2012-03-13 18:36:35, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4310/

        -----------------------------------------------------------

        (Updated 2012-03-13 18:36:35)

        Review request for shindig.

        Summary

        -------

        Updated sample gadgets.

        Added a dummy listener to the selection queue so that a gadget will always watch selection.

        Selection registration now returns the current selection so that gadgets can prime their selection cache.

        This addresses bug SHINDIG-1727.

        https://issues.apache.org/jira/browse/SHINDIG-1727

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267

        Diff: https://reviews.apache.org/r/4310/diff

        Testing

        -------

        Updated and ran unit tests.

        Updated sample gadgets, ran sample gadgets in the sample container.

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5935 ----------------------------------------------------------- Ship it! LGTM Stanton On 2012-03-13 18:36:35, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ ----------------------------------------------------------- (Updated 2012-03-13 18:36:35) Review request for shindig. Summary ------- Updated sample gadgets. Added a dummy listener to the selection queue so that a gadget will always watch selection. Selection registration now returns the current selection so that gadgets can prime their selection cache. This addresses bug SHINDIG-1727 . https://issues.apache.org/jira/browse/SHINDIG-1727 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267 Diff: https://reviews.apache.org/r/4310/diff Testing ------- Updated and ran unit tests. Updated sample gadgets, ran sample gadgets in the sample container. Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4310/#review5936
        -----------------------------------------------------------

        Ship it!

        Committed r1300552

        • Dan

        On 2012-03-13 18:36:35, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4310/

        -----------------------------------------------------------

        (Updated 2012-03-13 18:36:35)

        Review request for shindig.

        Summary

        -------

        Updated sample gadgets.

        Added a dummy listener to the selection queue so that a gadget will always watch selection.

        Selection registration now returns the current selection so that gadgets can prime their selection cache.

        This addresses bug SHINDIG-1727.

        https://issues.apache.org/jira/browse/SHINDIG-1727

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267

        Diff: https://reviews.apache.org/r/4310/diff

        Testing

        -------

        Updated and ran unit tests.

        Updated sample gadgets, ran sample gadgets in the sample container.

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/#review5936 ----------------------------------------------------------- Ship it! Committed r1300552 Dan On 2012-03-13 18:36:35, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4310/ ----------------------------------------------------------- (Updated 2012-03-13 18:36:35) Review request for shindig. Summary ------- Updated sample gadgets. Added a dummy listener to the selection queue so that a gadget will always watch selection. Selection registration now returns the current selection so that gadgets can prime their selection cache. This addresses bug SHINDIG-1727 . https://issues.apache.org/jira/browse/SHINDIG-1727 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-changer.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-listener.xml 1300267 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-selection-query.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js 1300267 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/selection/selection_test.js 1300267 Diff: https://reviews.apache.org/r/4310/diff Testing ------- Updated and ran unit tests. Updated sample gadgets, ran sample gadgets in the sample container. Thanks, Dan
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.

          People

          • Assignee:
            Dan Dumont
            Reporter:
            Bernadette Alexia Carter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development