Shindig
  1. Shindig
  2. SHINDIG-1725

osapi.container.util.warn causes errors when used in Internet Explorer

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Javascript
    • Labels:
      None
    • Environment:
      Internet Explorer 8

      Description

      osapi.container.util.warn uses "console" to do logging. IE complains when "console" is undefined even though the code is checking truthiness.

      osapi.container.util.warn is only used by osapi.container.GadgetSite.prototype.navigateTo and the proposed fix would be to remove osapi.container.util.warn completely and replace it with gadgets.warn, which handles the console object appropriately across browsers.

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4247/
        -----------------------------------------------------------

        Review request for shindig.

        Summary
        -------

        Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead.

        This addresses bug SHINDIG-1725.
        https://issues.apache.org/jira/browse/SHINDIG-1725

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060

        Diff: https://reviews.apache.org/r/4247/diff

        Testing
        -------

        Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/ ----------------------------------------------------------- Review request for shindig. Summary ------- Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead. This addresses bug SHINDIG-1725 . https://issues.apache.org/jira/browse/SHINDIG-1725 Diffs http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060 Diff: https://reviews.apache.org/r/4247/diff Testing ------- Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig. Thanks, Stanton
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4247/#review5746
        -----------------------------------------------------------

        Ship it!

        +1

        • Henry

        On 2012-03-08 17:30:51, Stanton Sievers wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4247/

        -----------------------------------------------------------

        (Updated 2012-03-08 17:30:51)

        Review request for shindig.

        Summary

        -------

        Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead.

        This addresses bug SHINDIG-1725.

        https://issues.apache.org/jira/browse/SHINDIG-1725

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060

        Diff: https://reviews.apache.org/r/4247/diff

        Testing

        -------

        Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/#review5746 ----------------------------------------------------------- Ship it! +1 Henry On 2012-03-08 17:30:51, Stanton Sievers wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/ ----------------------------------------------------------- (Updated 2012-03-08 17:30:51) Review request for shindig. Summary ------- Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead. This addresses bug SHINDIG-1725 . https://issues.apache.org/jira/browse/SHINDIG-1725 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060 Diff: https://reviews.apache.org/r/4247/diff Testing ------- Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig. Thanks, Stanton
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4247/#review5790
        -----------------------------------------------------------

        Ship it!

        LGTM

        • Ryan

        On 2012-03-08 17:30:51, Stanton Sievers wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4247/

        -----------------------------------------------------------

        (Updated 2012-03-08 17:30:51)

        Review request for shindig.

        Summary

        -------

        Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead.

        This addresses bug SHINDIG-1725.

        https://issues.apache.org/jira/browse/SHINDIG-1725

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060

        Diff: https://reviews.apache.org/r/4247/diff

        Testing

        -------

        Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/#review5790 ----------------------------------------------------------- Ship it! LGTM Ryan On 2012-03-08 17:30:51, Stanton Sievers wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/ ----------------------------------------------------------- (Updated 2012-03-08 17:30:51) Review request for shindig. Summary ------- Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead. This addresses bug SHINDIG-1725 . https://issues.apache.org/jira/browse/SHINDIG-1725 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060 Diff: https://reviews.apache.org/r/4247/diff Testing ------- Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig. Thanks, Stanton
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/4247/#review5796
        -----------------------------------------------------------

        Ship it!

        Committed revision 1298995.

        • Stanton

        On 2012-03-08 17:30:51, Stanton Sievers wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/4247/

        -----------------------------------------------------------

        (Updated 2012-03-08 17:30:51)

        Review request for shindig.

        Summary

        -------

        Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead.

        This addresses bug SHINDIG-1725.

        https://issues.apache.org/jira/browse/SHINDIG-1725

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060

        Diff: https://reviews.apache.org/r/4247/diff

        Testing

        -------

        Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/#review5796 ----------------------------------------------------------- Ship it! Committed revision 1298995. Stanton On 2012-03-08 17:30:51, Stanton Sievers wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4247/ ----------------------------------------------------------- (Updated 2012-03-08 17:30:51) Review request for shindig. Summary ------- Remove osapi.container.util.warn because it only serves to cause issues in IE. Replace it with gadgets.warn instead. This addresses bug SHINDIG-1725 . https://issues.apache.org/jira/browse/SHINDIG-1725 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/index.html 1298060 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_site.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1298060 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js 1298060 Diff: https://reviews.apache.org/r/4247/diff Testing ------- Modified the sample common container to allow me to hit the code paths I'm testing. These changes are part of the patch and I can drop them if we really don't want them going back to Shindig. Thanks, Stanton
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.

          People

          • Assignee:
            Stanton Sievers
            Reporter:
            Stanton Sievers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development