Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Java
    • Labels:
      None

      Description

      CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

      As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems.

      1. CheckStyle_v3.patch
        15 kB
        Stanton Sievers

        Activity

        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3959/#review5253
        -----------------------------------------------------------

        Ship it!

        Committed revision 1292048

        • Stanton

        On 2012-02-20 14:14:35, Stanton Sievers wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3959/

        -----------------------------------------------------------

        (Updated 2012-02-20 14:14:35)

        Review request for shindig.

        Summary

        -------

        CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

        As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems.

        There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix.

        The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well.

        This addresses bug SHINDIG-1710.

        https://issues.apache.org/jira/browse/SHINDIG-1710

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013

        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013

        http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013

        Diff: https://reviews.apache.org/r/3959/diff

        Testing

        -------

        Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/#review5253 ----------------------------------------------------------- Ship it! Committed revision 1292048 Stanton On 2012-02-20 14:14:35, Stanton Sievers wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/ ----------------------------------------------------------- (Updated 2012-02-20 14:14:35) Review request for shindig. Summary ------- CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated. As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems. There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix. The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well. This addresses bug SHINDIG-1710 . https://issues.apache.org/jira/browse/SHINDIG-1710 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013 http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013 http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013 Diff: https://reviews.apache.org/r/3959/diff Testing ------- Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs. Thanks, Stanton
        Hide
        Stanton Sievers added a comment -

        Committed revision 1292048

        Show
        Stanton Sievers added a comment - Committed revision 1292048
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3959/#review5240
        -----------------------------------------------------------

        Ship it!

        LGTM should help alot.

        • Ryan

        On 2012-02-20 14:14:35, Stanton Sievers wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3959/

        -----------------------------------------------------------

        (Updated 2012-02-20 14:14:35)

        Review request for shindig.

        Summary

        -------

        CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

        As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems.

        There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix.

        The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well.

        This addresses bug SHINDIG-1710.

        https://issues.apache.org/jira/browse/SHINDIG-1710

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013

        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013

        http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013

        Diff: https://reviews.apache.org/r/3959/diff

        Testing

        -------

        Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/#review5240 ----------------------------------------------------------- Ship it! LGTM should help alot. Ryan On 2012-02-20 14:14:35, Stanton Sievers wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/ ----------------------------------------------------------- (Updated 2012-02-20 14:14:35) Review request for shindig. Summary ------- CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated. As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems. There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix. The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well. This addresses bug SHINDIG-1710 . https://issues.apache.org/jira/browse/SHINDIG-1710 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013 http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013 http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013 Diff: https://reviews.apache.org/r/3959/diff Testing ------- Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs. Thanks, Stanton
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3959/
        -----------------------------------------------------------

        (Updated 2012-02-20 14:14:35.627793)

        Review request for shindig.

        Changes
        -------

        Ran through https://cwiki.apache.org/SHINDIGxSITE/java-style.html one more time and tweaked some things. Added some more information where appropriate.

        I'll go ahead and deliver this by EOD tomorrow if no one has any other comments.

        Summary
        -------

        CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

        As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems.

        There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix.

        The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well.

        This addresses bug SHINDIG-1710.
        https://issues.apache.org/jira/browse/SHINDIG-1710

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013
        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013
        http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013

        Diff: https://reviews.apache.org/r/3959/diff

        Testing
        -------

        Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/ ----------------------------------------------------------- (Updated 2012-02-20 14:14:35.627793) Review request for shindig. Changes ------- Ran through https://cwiki.apache.org/SHINDIGxSITE/java-style.html one more time and tweaked some things. Added some more information where appropriate. I'll go ahead and deliver this by EOD tomorrow if no one has any other comments. Summary ------- CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated. As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems. There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix. The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well. This addresses bug SHINDIG-1710 . https://issues.apache.org/jira/browse/SHINDIG-1710 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013 http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013 http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013 Diff: https://reviews.apache.org/r/3959/diff Testing ------- Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs. Thanks, Stanton
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3959/
        -----------------------------------------------------------

        (Updated 2012-02-19 20:25:08.168369)

        Review request for shindig.

        Changes
        -------

        Removing trailing whitespace from files.... trying to ignore the irony.

        Summary
        -------

        CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

        As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems.

        There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix.

        The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well.

        This addresses bug SHINDIG-1710.
        https://issues.apache.org/jira/browse/SHINDIG-1710

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013
        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013
        http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013

        Diff: https://reviews.apache.org/r/3959/diff

        Testing
        -------

        Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/ ----------------------------------------------------------- (Updated 2012-02-19 20:25:08.168369) Review request for shindig. Changes ------- Removing trailing whitespace from files.... trying to ignore the irony. Summary ------- CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated. As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems. There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix. The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well. This addresses bug SHINDIG-1710 . https://issues.apache.org/jira/browse/SHINDIG-1710 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013 http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013 http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013 Diff: https://reviews.apache.org/r/3959/diff Testing ------- Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs. Thanks, Stanton
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3959/#review5212
        -----------------------------------------------------------

        Ship it!

        thanks for cleaning this up!

        http://svn.apache.org/repos/asf/shindig/trunk/pom.xml
        <https://reviews.apache.org/r/3959/#comment11404>

        nit: trailing whitespace.

        • Paul

        On 2012-02-19 15:35:35, Stanton Sievers wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3959/

        -----------------------------------------------------------

        (Updated 2012-02-19 15:35:35)

        Review request for shindig.

        Summary

        -------

        CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

        As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems.

        There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix.

        The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well.

        This addresses bug SHINDIG-1710.

        https://issues.apache.org/jira/browse/SHINDIG-1710

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013

        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013

        http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013

        Diff: https://reviews.apache.org/r/3959/diff

        Testing

        -------

        Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/#review5212 ----------------------------------------------------------- Ship it! thanks for cleaning this up! http://svn.apache.org/repos/asf/shindig/trunk/pom.xml < https://reviews.apache.org/r/3959/#comment11404 > nit: trailing whitespace. Paul On 2012-02-19 15:35:35, Stanton Sievers wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/ ----------------------------------------------------------- (Updated 2012-02-19 15:35:35) Review request for shindig. Summary ------- CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated. As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems. There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix. The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well. This addresses bug SHINDIG-1710 . https://issues.apache.org/jira/browse/SHINDIG-1710 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013 http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013 http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013 Diff: https://reviews.apache.org/r/3959/diff Testing ------- Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs. Thanks, Stanton
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3959/
        -----------------------------------------------------------

        Review request for shindig.

        Summary
        -------

        CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated.

        As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems.

        There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix.

        The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well.

        This addresses bug SHINDIG-1710.
        https://issues.apache.org/jira/browse/SHINDIG-1710

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013
        http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013
        http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013

        Diff: https://reviews.apache.org/r/3959/diff

        Testing
        -------

        Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs.

        Thanks,

        Stanton

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3959/ ----------------------------------------------------------- Review request for shindig. Summary ------- CheckStyle is commented out in the main pom.xml with a todo to re-enable it. I want to re-enable it and fixup the CheckStyle configuration to match the best practices on the wiki. It also appears that the CheckStyle configuration currently in Shindig is an older configuration style - some config has moved in the file and some attributes have been renamed or invalidated. As a followup to this JIRA (or perhaps as part of it), I'd like to fix some of the more obvious style problems. There are some mismatches between the headers in some of the files. I updated the java.header to match the header provided in the Eclipse template config, however, this causes mismatches in some existing files whose headers do not match. This is one of the "obvious style problems" I mentioned above that I will fix. The other obvious things to fix would be trailing whitespace, which can easily be fixed with a script that runs against all *.java files. If this is worth fixing, I can do that as well. This addresses bug SHINDIG-1710 . https://issues.apache.org/jira/browse/SHINDIG-1710 Diffs http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/checkstyle.xml 1291013 http://svn.apache.org/repos/asf/shindig/trunk/etc/checkstyle/java.header 1291013 http://svn.apache.org/repos/asf/shindig/trunk/pom.xml 1291013 Diff: https://reviews.apache.org/r/3959/diff Testing ------- Ran "mvn -Pall,reporting,samples clean install checkstyle:checkstyle" and examined the checkstyle outputs. Thanks, Stanton

          People

          • Assignee:
            Stanton Sievers
            Reporter:
            Stanton Sievers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development