Shindig
  1. Shindig
  2. SHINDIG-1699

Remove the extra gadgets.config.init call in the common container code

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Javascript
    • Labels:
      None

      Description

      The common container init.js contains call to gadgets.config.init to initialize config for rpc and core.io.

      However, this initialization will be overwritten by the new JS serving flow. The class ConfigInjectionProcessor will add call to gadgets.config.init to inject config from the container.js file.

      I think the config init in the common container is not necessary anymore.

        Activity

        Henry Saputra created issue -
        Henry Saputra made changes -
        Field Original Value New Value
        Priority Major [ 3 ] Minor [ 4 ]
        Henry Saputra made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Henry Saputra [ hsaputra ]
        Fix Version/s 3.0.0 [ 12315324 ]
        Henry Saputra made changes -
        Attachment SHINDIG-1699.patch [ 12513286 ]
        Hide
        Henry Saputra added a comment -

        Committed revision 1240864

        Show
        Henry Saputra added a comment - Committed revision 1240864
        Henry Saputra made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.
        Paul Lindner made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Henry Saputra
            Reporter:
            Henry Saputra
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development