[SHINDIG-1696] calling gadgets.window.adjustWidth results in infinite loop

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.5.0-beta1
• Fix Version/s: 2.5.0-beta1
• Component/s: Javascript
• Labels: patch
• Assignee: Unassigned
• Reporter: Li Xu
• Created: 01/Feb/12 20:08
• Updated: 17/Jul/13 09:55
• Resolved: 15/Feb/12 21:20

Description

This is a fix from Sarah Brolley. Thanks!

The problem is that it didn't pass in the newWidth when calling adjustWidth in the call back function.

var callback = null;
if (isNaN(opt_width) && viewportWidth >= newWidth) {
// Due to quirks in the width property, the auto-calculated width will
// never be smaller than the size of the viewport. In order to decrease
// the width to a fit size, we must first make the viewport too small (1px),
// then callback a function that increases the frame to the right width.
callback = function()

{ gadgets.window.adjustWidth(); ---> FIX: should pass in the new Width here }

;
newWidth = 1;
}
gadgets.rpc.call(null, 'resize_iframe_width', callback, newWidth);