Shindig
  1. Shindig
  2. SHINDIG-1695

new core-gadget feature "proxied-form-post" gadgets.proxiedMultipartFormPost

    Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

      It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

      1. shindig.patch
        42 kB
        Dan Dumont

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/
        -----------------------------------------------------------

        Review request for Ryan Baxter and Stanton Sievers.

        Summary
        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.
        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing
        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/
        -----------------------------------------------------------

        (Updated 2012-02-07 02:31:39.135167)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary
        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.
        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing
        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 02:31:39.135167) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4857
        -----------------------------------------------------------

        LGTM for the most part. Kudos on killing whitespace like it's your job.

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
        <https://reviews.apache.org/r/3768/#comment10666>

        Is this supposed 5MB or 5MiB? You seem to have gone 5MiB.

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
        <https://reviews.apache.org/r/3768/#comment10667>

        What's the reasoning behind doing this? Not saying there's something wrong with it, but would like to understand the change.

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
        <https://reviews.apache.org/r/3768/#comment10668>

        Need boilerplate Apache header. If Eclipse didn't add that for you automagically, we should look at updating the Eclipse IDE templates for .js files.

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
        <https://reviews.apache.org/r/3768/#comment10670>

        It would be nice to comment that this is IE only (right?) so that it makes sense as people scan the code.

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
        <https://reviews.apache.org/r/3768/#comment10669>

        Do we know why appendChild() was being avoided in other places in the code where we setup the gadget iframes?

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
        <https://reviews.apache.org/r/3768/#comment10671>

        Should onprogress be optional if it's not going to work in all cases? Maybe make it optional and also make it the last param.

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java
        <https://reviews.apache.org/r/3768/#comment10672>

        Does it? Looks like you're catching and logging.

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
        <https://reviews.apache.org/r/3768/#comment10673>

        "The" not "There".... sorry.

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java
        <https://reviews.apache.org/r/3768/#comment10674>

        I would make the max post size a constant somewhere.

        • Stanton

        On 2012-02-07 02:31:39, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-07 02:31:39)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4857 ----------------------------------------------------------- LGTM for the most part. Kudos on killing whitespace like it's your job. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js < https://reviews.apache.org/r/3768/#comment10666 > Is this supposed 5MB or 5MiB? You seem to have gone 5MiB. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js < https://reviews.apache.org/r/3768/#comment10667 > What's the reasoning behind doing this? Not saying there's something wrong with it, but would like to understand the change. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js < https://reviews.apache.org/r/3768/#comment10668 > Need boilerplate Apache header. If Eclipse didn't add that for you automagically, we should look at updating the Eclipse IDE templates for .js files. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js < https://reviews.apache.org/r/3768/#comment10670 > It would be nice to comment that this is IE only (right?) so that it makes sense as people scan the code. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js < https://reviews.apache.org/r/3768/#comment10669 > Do we know why appendChild() was being avoided in other places in the code where we setup the gadget iframes? http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js < https://reviews.apache.org/r/3768/#comment10671 > Should onprogress be optional if it's not going to work in all cases? Maybe make it optional and also make it the last param. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java < https://reviews.apache.org/r/3768/#comment10672 > Does it? Looks like you're catching and logging. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java < https://reviews.apache.org/r/3768/#comment10673 > "The" not "There".... sorry. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java < https://reviews.apache.org/r/3768/#comment10674 > I would make the max post size a constant somewhere. Stanton On 2012-02-07 02:31:39, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 02:31:39) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js, line 144

        > <https://reviews.apache.org/r/3768/diff/3/?file=72702#file72702line144>

        >

        > Is this supposed 5MB or 5MiB? You seem to have gone 5MiB.

        MiB, sorry. I'll fix the comment.

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js, line 178

        > <https://reviews.apache.org/r/3768/diff/3/?file=72704#file72704line178>

        >

        > What's the reasoning behind doing this? Not saying there's something wrong with it, but would like to understand the change.

        Here's an explanation: http://www.scottlogic.co.uk/2010/10/javascript-array-performance/

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 1

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line1>

        >

        > Need boilerplate Apache header. If Eclipse didn't add that for you automagically, we should look at updating the Eclipse IDE templates for .js files.

        Ahh yes. It did not.

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 19

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line19>

        >

        > It would be nice to comment that this is IE only (right?) so that it makes sense as people scan the code.

        And FF 3.6

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 26

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line26>

        >

        > Do we know why appendChild() was being avoided in other places in the code where we setup the gadget iframes?

        In that case we had a gadget site already in the DOM. setting innerHTML wasn't hard because we already had a container element.
        In this case, I can't set the innerHTML of the body tag, so I have to append the node.

        I don't think it matters too much because it only ever happens once.

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 68

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line68>

        >

        > Should onprogress be optional if it's not going to work in all cases? Maybe make it optional and also make it the last param.

        Yes, I'll update the comment.
        I don't think I'll be able to use the closure util if it needs to be last.

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java, line 194

        > <https://reviews.apache.org/r/3768/diff/3/?file=72711#file72711line194>

        >

        > Does it? Looks like you're catching and logging.

        Eclipse sneaked that in before when I wasn't. Will update.

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java, line 449

        > <https://reviews.apache.org/r/3768/diff/3/?file=72712#file72712line449>

        >

        > "The" not "There".... sorry.

        Don't be, my turn will come to catch yours

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java, line 472

        > <https://reviews.apache.org/r/3768/diff/3/?file=72712#file72712line472>

        >

        > I would make the max post size a constant somewhere.

        I can if you want. For something like this I don't think we need to clutter up the top of the class file, but I guess I don't care either way.
        It should always be provided by the config, this is just a precaution.

        • Dan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4857
        -----------------------------------------------------------

        On 2012-02-07 02:31:39, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-07 02:31:39)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/config/container.js , line 144 > < https://reviews.apache.org/r/3768/diff/3/?file=72702#file72702line144 > > > Is this supposed 5MB or 5MiB? You seem to have gone 5MiB. MiB, sorry. I'll fix the comment. On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js , line 178 > < https://reviews.apache.org/r/3768/diff/3/?file=72704#file72704line178 > > > What's the reasoning behind doing this? Not saying there's something wrong with it, but would like to understand the change. Here's an explanation: http://www.scottlogic.co.uk/2010/10/javascript-array-performance/ On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 1 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line1 > > > Need boilerplate Apache header. If Eclipse didn't add that for you automagically, we should look at updating the Eclipse IDE templates for .js files. Ahh yes. It did not. On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 19 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line19 > > > It would be nice to comment that this is IE only (right?) so that it makes sense as people scan the code. And FF 3.6 On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 26 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line26 > > > Do we know why appendChild() was being avoided in other places in the code where we setup the gadget iframes? In that case we had a gadget site already in the DOM. setting innerHTML wasn't hard because we already had a container element. In this case, I can't set the innerHTML of the body tag, so I have to append the node. I don't think it matters too much because it only ever happens once. On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 68 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line68 > > > Should onprogress be optional if it's not going to work in all cases? Maybe make it optional and also make it the last param. Yes, I'll update the comment. I don't think I'll be able to use the closure util if it needs to be last. On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java , line 194 > < https://reviews.apache.org/r/3768/diff/3/?file=72711#file72711line194 > > > Does it? Looks like you're catching and logging. Eclipse sneaked that in before when I wasn't. Will update. On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java , line 449 > < https://reviews.apache.org/r/3768/diff/3/?file=72712#file72712line449 > > > "The" not "There".... sorry. Don't be, my turn will come to catch yours On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java , line 472 > < https://reviews.apache.org/r/3768/diff/3/?file=72712#file72712line472 > > > I would make the max post size a constant somewhere. I can if you want. For something like this I don't think we need to clutter up the top of the class file, but I guess I don't care either way. It should always be provided by the config, this is just a precaution. Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4857 ----------------------------------------------------------- On 2012-02-07 02:31:39, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 02:31:39) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-02-07 13:23:54, Stanton Sievers wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 68

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line68>

        >

        > Should onprogress be optional if it's not going to work in all cases? Maybe make it optional and also make it the last param.

        Dan Dumont wrote:

        Yes, I'll update the comment.

        I don't think I'll be able to use the closure util if it needs to be last.

        Never mind, I was thinking about xhr.abort param of the onprogress param, not the the onprogress param itself.

        • Dan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4857
        -----------------------------------------------------------

        On 2012-02-07 02:31:39, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-07 02:31:39)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-02-07 13:23:54, Stanton Sievers wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 68 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line68 > > > Should onprogress be optional if it's not going to work in all cases? Maybe make it optional and also make it the last param. Dan Dumont wrote: Yes, I'll update the comment. I don't think I'll be able to use the closure util if it needs to be last. Never mind, I was thinking about xhr.abort param of the onprogress param, not the the onprogress param itself. Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4857 ----------------------------------------------------------- On 2012-02-07 02:31:39, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 02:31:39) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/
        -----------------------------------------------------------

        (Updated 2012-02-07 14:49:32.113741)

        Review request for Ryan Baxter and Stanton Sievers.

        Changes
        -------

        Updates from feedback.

        Summary
        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.
        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing
        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 14:49:32.113741) Review request for Ryan Baxter and Stanton Sievers. Changes ------- Updates from feedback. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4861
        -----------------------------------------------------------

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml
        <https://reviews.apache.org/r/3768/#comment10686>

        Seems like this api would fit better in the gadgets.io namespace.

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
        <https://reviews.apache.org/r/3768/#comment10687>

        To be safe you probably also want to make sure that gadgets is already defined. I have seen feature code do gadgets.io = gadgets.io || {}.

        Also how much of this code is borrowed from the makeRequest code?

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js
        <https://reviews.apache.org/r/3768/#comment10685>

        Instead of throwing errors could we call the callback with an error?

        • Ryan

        On 2012-02-07 14:49:32, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-07 14:49:32)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4861 ----------------------------------------------------------- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml < https://reviews.apache.org/r/3768/#comment10686 > Seems like this api would fit better in the gadgets.io namespace. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js < https://reviews.apache.org/r/3768/#comment10687 > To be safe you probably also want to make sure that gadgets is already defined. I have seen feature code do gadgets.io = gadgets.io || {}. Also how much of this code is borrowed from the makeRequest code? http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js < https://reviews.apache.org/r/3768/#comment10685 > Instead of throwing errors could we call the callback with an error? Ryan On 2012-02-07 14:49:32, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 14:49:32) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-02-07 15:10:16, Ryan Baxter wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 91

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line91>

        >

        > Instead of throwing errors could we call the callback with an error?

        If the request were even attempted I would say yes, this is just sanity checking before we start.

        On 2012-02-07 15:10:16, Ryan Baxter wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml, line 35

        > <https://reviews.apache.org/r/3768/diff/3/?file=72707#file72707line35>

        >

        > Seems like this api would fit better in the gadgets.io namespace.

        Not sure about how much of gadgets.io Mark want's to deprecate.
        Also, currently it seems like the entire io feature is included by core and always available. To avoid confusion, I wanted to make it separate... though you're right it is IO.

        I saw some talk of how to define what apis are in what features. Not sure where I really want to put this function. I'll address it later when I get more feedback from Mark as he does the spec for the feature.

        On 2012-02-07 15:10:16, Ryan Baxter wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 1

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line1>

        >

        > To be safe you probably also want to make sure that gadgets is already defined. I have seen feature code do gadgets.io = gadgets.io || {}.

        >

        > Also how much of this code is borrowed from the makeRequest code?

        I'll look into it.

        • Dan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4861
        -----------------------------------------------------------

        On 2012-02-07 14:49:32, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-07 14:49:32)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-02-07 15:10:16, Ryan Baxter wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 91 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line91 > > > Instead of throwing errors could we call the callback with an error? If the request were even attempted I would say yes, this is just sanity checking before we start. On 2012-02-07 15:10:16, Ryan Baxter wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml , line 35 > < https://reviews.apache.org/r/3768/diff/3/?file=72707#file72707line35 > > > Seems like this api would fit better in the gadgets.io namespace. Not sure about how much of gadgets.io Mark want's to deprecate. Also, currently it seems like the entire io feature is included by core and always available. To avoid confusion, I wanted to make it separate... though you're right it is IO. I saw some talk of how to define what apis are in what features. Not sure where I really want to put this function. I'll address it later when I get more feedback from Mark as he does the spec for the feature. On 2012-02-07 15:10:16, Ryan Baxter wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 1 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line1 > > > To be safe you probably also want to make sure that gadgets is already defined. I have seen feature code do gadgets.io = gadgets.io || {}. > > Also how much of this code is borrowed from the makeRequest code? I'll look into it. Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4861 ----------------------------------------------------------- On 2012-02-07 14:49:32, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 14:49:32) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/
        -----------------------------------------------------------

        (Updated 2012-02-07 21:13:45.353118)

        Review request for Ryan Baxter and Stanton Sievers.

        Changes
        -------

        Caught some errors while testing.

        Summary
        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.
        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing
        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 21:13:45.353118) Review request for Ryan Baxter and Stanton Sievers. Changes ------- Caught some errors while testing. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2012-02-07 15:10:16, Ryan Baxter wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js, line 91

        > <https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line91>

        >

        > Instead of throwing errors could we call the callback with an error?

        Dan Dumont wrote:

        If the request were even attempted I would say yes, this is just sanity checking before we start.

        I just think it is cleaner in the gadget code to always have your callback called regardless of where the error occurred.

        • Ryan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4861
        -----------------------------------------------------------

        On 2012-02-07 21:13:45, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-07 21:13:45)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - On 2012-02-07 15:10:16, Ryan Baxter wrote: > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js , line 91 > < https://reviews.apache.org/r/3768/diff/3/?file=72708#file72708line91 > > > Instead of throwing errors could we call the callback with an error? Dan Dumont wrote: If the request were even attempted I would say yes, this is just sanity checking before we start. I just think it is cleaner in the gadget code to always have your callback called regardless of where the error occurred. Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4861 ----------------------------------------------------------- On 2012-02-07 21:13:45, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-07 21:13:45) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/
        -----------------------------------------------------------

        (Updated 2012-02-08 16:48:54.492574)

        Review request for Ryan Baxter and Stanton Sievers.

        Changes
        -------

        Moved api to gadgets.io namespace.
        Added clarifying comments to the function.
        Added ability to supply a FormData object in the case an application manages multiple file selection manually and wishes to provide a built FormData object.

        Summary
        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.
        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing
        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-08 16:48:54.492574) Review request for Ryan Baxter and Stanton Sievers. Changes ------- Moved api to gadgets.io namespace. Added clarifying comments to the function. Added ability to supply a FormData object in the case an application manages multiple file selection manually and wishes to provide a built FormData object. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4908
        -----------------------------------------------------------

        LGTM I think this is ready to be opened up to the public list.

        • Ryan

        On 2012-02-08 16:48:54, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-08 16:48:54)

        Review request for Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4908 ----------------------------------------------------------- LGTM I think this is ready to be opened up to the public list. Ryan On 2012-02-08 16:48:54, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-08 16:48:54) Review request for Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/
        -----------------------------------------------------------

        (Updated 2012-02-08 19:35:27.423243)

        Review request for shindig, Ryan Baxter and Stanton Sievers.

        Changes
        -------

        Adding shindig to review.
        Will add a test gadget soon (still adding things to it)

        Summary
        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.
        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing
        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-08 19:35:27.423243) Review request for shindig, Ryan Baxter and Stanton Sievers. Changes ------- Adding shindig to review. Will add a test gadget soon (still adding things to it) Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/
        -----------------------------------------------------------

        (Updated 2012-02-08 20:29:31.024305)

        Review request for shindig, Ryan Baxter and Stanton Sievers.

        Changes
        -------

        Adding an example gadget.

        Summary
        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.
        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing
        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-08 20:29:31.024305) Review request for shindig, Ryan Baxter and Stanton Sievers. Changes ------- Adding an example gadget. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review4981
        -----------------------------------------------------------

        I plan on delivering this EOD tomrrow (Friday, Feb 10th) unless any interested parties request more time to review or post reviews requiring a change. Please let me know.

        • Dan

        On 2012-02-08 20:29:31, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-08 20:29:31)

        Review request for shindig, Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review4981 ----------------------------------------------------------- I plan on delivering this EOD tomrrow (Friday, Feb 10th) unless any interested parties request more time to review or post reviews requiring a change. Please let me know. Dan On 2012-02-08 20:29:31, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-08 20:29:31) Review request for shindig, Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review5011
        -----------------------------------------------------------

        Ship it!

        LGTM

        • Jesse

        On 2012-02-08 20:29:31, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-08 20:29:31)

        Review request for shindig, Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review5011 ----------------------------------------------------------- Ship it! LGTM Jesse On 2012-02-08 20:29:31, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-08 20:29:31) Review request for shindig, Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan
        Hide
        Dan Dumont added a comment -

        Committed r1242959

        Show
        Dan Dumont added a comment - Committed r1242959
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3768/#review5013
        -----------------------------------------------------------

        Ship it!

        Committed r1242959

        • Dan

        On 2012-02-08 20:29:31, Dan Dumont wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3768/

        -----------------------------------------------------------

        (Updated 2012-02-08 20:29:31)

        Review request for shindig, Ryan Baxter and Stanton Sievers.

        Summary

        -------

        With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested.

        It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available.

        This addresses bug SHINDIG-1695.

        https://issues.apache.org/jira/browse/SHINDIG-1695

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308

        Diff: https://reviews.apache.org/r/3768/diff

        Testing

        -------

        Thanks,

        Dan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/#review5013 ----------------------------------------------------------- Ship it! Committed r1242959 Dan On 2012-02-08 20:29:31, Dan Dumont wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3768/ ----------------------------------------------------------- (Updated 2012-02-08 20:29:31) Review request for shindig, Ryan Baxter and Stanton Sievers. Summary ------- With the desire to deprecate the makeRequest API, we still need a method to post files through the proxy. This new feature should not be bundled in with core, it should need to be explicitly requested. It should allow modern browsers such as FF and Chrome to monitor form post progress. It should still be functional (do the post) for less capable browsers like IE, even though post progress may not be available. This addresses bug SHINDIG-1695 . https://issues.apache.org/jira/browse/SHINDIG-1695 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/post.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1241308 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/ImageUploadGadget.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/config/container.js 1241308 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/proxied-form-post/taming.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/GadgetException.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/MakeRequestHandler.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestHandlerTest.java 1241308 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/MakeRequestServletTest.java 1241308 Diff: https://reviews.apache.org/r/3768/diff Testing ------- Thanks, Dan

          People

          • Assignee:
            Dan Dumont
            Reporter:
            Dan Dumont
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development