Shindig
  1. Shindig
  2. SHINDIG-1643

Gadget Admin Code Does Not Take Into Account Ports In Gadget URLs

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0-beta1
    • Component/s: None
    • Labels:
      None

      Description

      If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 6h 31m 1 Ryan Baxter 20/Oct/11 00:53
        Patch Available Patch Available Resolved Resolved
        11s 1 Ryan Baxter 20/Oct/11 00:53
        Resolved Resolved Closed Closed
        161d 21h 5m 1 Paul Lindner 29/Mar/12 21:58
        Paul Lindner made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.
        Ryan Baxter made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Ryan Baxter added a comment -

        Committed revision 1186569.

        Show
        Ryan Baxter added a comment - Committed revision 1186569.
        Ryan Baxter made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ryan Baxter added a comment -

        Committed revision 1186569.

        Show
        Ryan Baxter added a comment - Committed revision 1186569.
        Ryan Baxter made changes -
        Field Original Value New Value
        Attachment issue-1643.patch [ 12499783 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2425/
        -----------------------------------------------------------

        (Updated 2011-10-19 01:21:49.752578)

        Review request for shindig and Dan Dumont.

        Changes
        -------

        Updated based on Dans comments.

        Summary
        -------

        If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.

        This addresses bug SHINDIG-1643.
        https://issues.apache.org/jira/browse/SHINDIG-1643

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758

        Diff: https://reviews.apache.org/r/2425/diff

        Testing
        -------

        Updated unit tests to test new functionality

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/ ----------------------------------------------------------- (Updated 2011-10-19 01:21:49.752578) Review request for shindig and Dan Dumont. Changes ------- Updated based on Dans comments. Summary ------- If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render. This addresses bug SHINDIG-1643 . https://issues.apache.org/jira/browse/SHINDIG-1643 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758 Diff: https://reviews.apache.org/r/2425/diff Testing ------- Updated unit tests to test new functionality Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-10-18 18:34:38, Dan Dumont wrote:

        > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java, line 185

        > <https://reviews.apache.org/r/2425/diff/2/?file=50897#file50897line185>

        >

        > else if, to avoid checks if the 1st one matched.

        Otherwise, LGTM

        • Dan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2425/#review2653
        -----------------------------------------------------------

        On 2011-10-18 18:13:24, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2425/

        -----------------------------------------------------------

        (Updated 2011-10-18 18:13:24)

        Review request for shindig and Dan Dumont.

        Summary

        -------

        If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.

        This addresses bug SHINDIG-1643.

        https://issues.apache.org/jira/browse/SHINDIG-1643

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758

        Diff: https://reviews.apache.org/r/2425/diff

        Testing

        -------

        Updated unit tests to test new functionality

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-10-18 18:34:38, Dan Dumont wrote: > http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java , line 185 > < https://reviews.apache.org/r/2425/diff/2/?file=50897#file50897line185 > > > else if, to avoid checks if the 1st one matched. Otherwise, LGTM Dan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/#review2653 ----------------------------------------------------------- On 2011-10-18 18:13:24, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/ ----------------------------------------------------------- (Updated 2011-10-18 18:13:24) Review request for shindig and Dan Dumont. Summary ------- If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render. This addresses bug SHINDIG-1643 . https://issues.apache.org/jira/browse/SHINDIG-1643 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758 Diff: https://reviews.apache.org/r/2425/diff Testing ------- Updated unit tests to test new functionality Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2425/#review2653
        -----------------------------------------------------------

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java
        <https://reviews.apache.org/r/2425/#comment5971>

        else if, to avoid checks if the 1st one matched.

        • Dan

        On 2011-10-18 18:13:24, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2425/

        -----------------------------------------------------------

        (Updated 2011-10-18 18:13:24)

        Review request for shindig and Dan Dumont.

        Summary

        -------

        If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.

        This addresses bug SHINDIG-1643.

        https://issues.apache.org/jira/browse/SHINDIG-1643

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758

        Diff: https://reviews.apache.org/r/2425/diff

        Testing

        -------

        Updated unit tests to test new functionality

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/#review2653 ----------------------------------------------------------- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java < https://reviews.apache.org/r/2425/#comment5971 > else if, to avoid checks if the 1st one matched. Dan On 2011-10-18 18:13:24, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/ ----------------------------------------------------------- (Updated 2011-10-18 18:13:24) Review request for shindig and Dan Dumont. Summary ------- If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render. This addresses bug SHINDIG-1643 . https://issues.apache.org/jira/browse/SHINDIG-1643 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758 Diff: https://reviews.apache.org/r/2425/diff Testing ------- Updated unit tests to test new functionality Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2425/
        -----------------------------------------------------------

        (Updated 2011-10-18 18:13:24.355658)

        Review request for shindig and Dan Dumont.

        Changes
        -------

        Removed white spaces

        Summary
        -------

        If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.

        This addresses bug SHINDIG-1643.
        https://issues.apache.org/jira/browse/SHINDIG-1643

        Diffs (updated)


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758

        Diff: https://reviews.apache.org/r/2425/diff

        Testing
        -------

        Updated unit tests to test new functionality

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/ ----------------------------------------------------------- (Updated 2011-10-18 18:13:24.355658) Review request for shindig and Dan Dumont. Changes ------- Removed white spaces Summary ------- If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render. This addresses bug SHINDIG-1643 . https://issues.apache.org/jira/browse/SHINDIG-1643 Diffs (updated) http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758 Diff: https://reviews.apache.org/r/2425/diff Testing ------- Updated unit tests to test new functionality Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2425/
        -----------------------------------------------------------

        Review request for shindig and Dan Dumont.

        Summary
        -------

        If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render.

        This addresses bug SHINDIG-1643.
        https://issues.apache.org/jira/browse/SHINDIG-1643

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758
        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758

        Diff: https://reviews.apache.org/r/2425/diff

        Testing
        -------

        Updated unit tests to test new functionality

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2425/ ----------------------------------------------------------- Review request for shindig and Dan Dumont. Summary ------- If there is a gadget in the admin store, for example http://foo.com/gadget.xml and we try to render http://foo.com:80/gadget.xml shindig does not think http://foo.com:80/gadget.xml is the same as http://foo.com/gadget.xml are the same gadget so it does not think the gadget should be allowed to render. This addresses bug SHINDIG-1643 . https://issues.apache.org/jira/browse/SHINDIG-1643 Diffs http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/admin/ContainerAdminData.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/BasicGadgetAdminStoreTest.java 1185758 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/admin/ContainerAdminDataTest.java 1185758 Diff: https://reviews.apache.org/r/2425/diff Testing ------- Updated unit tests to test new functionality Thanks, Ryan
        Ryan Baxter created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Ryan Baxter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4h
              4h
              Remaining:
              Remaining Estimate - 4h
              4h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development