Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta1
    • Component/s: None
    • Labels:
      None

      Description

      GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.

      1. issue-1634.patch
        0.9 kB
        Ryan Baxter

        Activity

        Ryan Baxter created issue -
        Ryan Baxter made changes -
        Field Original Value New Value
        Attachment issue-1634.patch [ 12497472 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2149/
        -----------------------------------------------------------

        Review request for shindig, Henry Saputra and Dan Dumont.

        Summary
        -------

        GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.

        This addresses bug SHINDIG-1634.
        https://issues.apache.org/jira/browse/SHINDIG-1634

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236

        Diff: https://reviews.apache.org/r/2149/diff

        Testing
        -------

        Ran mvn build

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2149/ ----------------------------------------------------------- Review request for shindig, Henry Saputra and Dan Dumont. Summary ------- GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different. This addresses bug SHINDIG-1634 . https://issues.apache.org/jira/browse/SHINDIG-1634 Diffs http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236 Diff: https://reviews.apache.org/r/2149/diff Testing ------- Ran mvn build Thanks, Ryan
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2149/#review2264
        -----------------------------------------------------------

        Ship it!

        For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding

        • Paul

        On 2011-10-03 15:01:39, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2149/

        -----------------------------------------------------------

        (Updated 2011-10-03 15:01:39)

        Review request for shindig, Henry Saputra and Dan Dumont.

        Summary

        -------

        GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.

        This addresses bug SHINDIG-1634.

        https://issues.apache.org/jira/browse/SHINDIG-1634

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236

        Diff: https://reviews.apache.org/r/2149/diff

        Testing

        -------

        Ran mvn build

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2149/#review2264 ----------------------------------------------------------- Ship it! For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding Paul On 2011-10-03 15:01:39, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2149/ ----------------------------------------------------------- (Updated 2011-10-03 15:01:39) Review request for shindig, Henry Saputra and Dan Dumont. Summary ------- GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different. This addresses bug SHINDIG-1634 . https://issues.apache.org/jira/browse/SHINDIG-1634 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236 Diff: https://reviews.apache.org/r/2149/diff Testing ------- Ran mvn build Thanks, Ryan
        Hide
        Ryan Baxter added a comment -

        Committed revision 1178441.

        Show
        Ryan Baxter added a comment - Committed revision 1178441.
        Ryan Baxter made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 3.0.0 [ 12315324 ]
        Resolution Fixed [ 1 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        On 2011-10-03 16:07:31, Paul Lindner wrote:

        > For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding

        >

        Thanks Paul. We would all like more time coding.
        Committed revision 1178441.

        • Ryan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2149/#review2264
        -----------------------------------------------------------

        On 2011-10-03 15:01:39, Ryan Baxter wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2149/

        -----------------------------------------------------------

        (Updated 2011-10-03 15:01:39)

        Review request for shindig, Henry Saputra and Dan Dumont.

        Summary

        -------

        GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different.

        This addresses bug SHINDIG-1634.

        https://issues.apache.org/jira/browse/SHINDIG-1634

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236

        Diff: https://reviews.apache.org/r/2149/diff

        Testing

        -------

        Ran mvn build

        Thanks,

        Ryan

        Show
        jiraposter@reviews.apache.org added a comment - On 2011-10-03 16:07:31, Paul Lindner wrote: > For the future: since you're a committer and have CLA on file I'd just go ahead and submit non-feature related fixes like this directly. Less time clicking in jira == more time coding > Thanks Paul. We would all like more time coding. Committed revision 1178441. Ryan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2149/#review2264 ----------------------------------------------------------- On 2011-10-03 15:01:39, Ryan Baxter wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2149/ ----------------------------------------------------------- (Updated 2011-10-03 15:01:39) Review request for shindig, Henry Saputra and Dan Dumont. Summary ------- GadgetHandlerTest.testAllowedRpcSercurityIds could potentially fail depending on the order the RPC service IDs returned in the JSON array. The code in GadgetsHandlerService returns the IDs in a set which does note guarantee order, so the order of the IDs in the JSON array may be different. This addresses bug SHINDIG-1634 . https://issues.apache.org/jira/browse/SHINDIG-1634 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1178236 Diff: https://reviews.apache.org/r/2149/diff Testing ------- Ran mvn build Thanks, Ryan
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.
        Paul Lindner made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Ryan Baxter
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1h
              1h
              Remaining:
              Remaining Estimate - 1h
              1h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development