Shindig
  1. Shindig
  2. SHINDIG-1592

EE sample gadget doesn't work out of box if deployed with context other than root or deployed on port other than 8080

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Java
    • Labels:

      Description

      This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080

      we added two tokens at sample db: canonicaldb.json
      %contextroot%
      %origin%
      it's resolved by JsonDBOpensocialService.java based on injected hostProvider
      This is a generic change... any other opensocial object could use the same token in sample json db.

      Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
      "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
      fixed related junit tests.

      Thanks to Ryan's help on this!

        Activity

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1616/
        -----------------------------------------------------------

        (Updated 2011-08-24 20:14:29.491196)

        Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.

        Changes
        -------

        Thanks for catching this, Ryan.
        is all the procedure documented somewhere? seems like I missed a few...

        Summary
        -------

        This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080

        we added two tokens at sample db: canonicaldb.json
        %contextroot%
        %origin%
        it's resolved by JsonDBOpensocialService.java based on injected hostProvider
        This is a generic change... any other opensocial object could use the same token in sample json db.

        Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml
        "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",
        fixed related junit tests.

        Thanks to Ryan's help on this!

        This addresses bug shindig-1592.
        https://issues.apache.org/jira/browse/shindig-1592

        Diffs


        /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372
        /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372
        /trunk/content/sampledata/canonicaldb.json 1160372
        /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372
        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372
        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372
        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372
        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372
        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372

        Diff: https://reviews.apache.org/r/1616/diff

        Testing
        -------

        Passed JUnit tests.
        Tested with /embeddedexperiences/index.html

        Thanks,

        li

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/ ----------------------------------------------------------- (Updated 2011-08-24 20:14:29.491196) Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter. Changes ------- Thanks for catching this, Ryan. is all the procedure documented somewhere? seems like I missed a few... Summary ------- This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080 we added two tokens at sample db: canonicaldb.json %contextroot% %origin% it's resolved by JsonDBOpensocialService.java based on injected hostProvider This is a generic change... any other opensocial object could use the same token in sample json db. Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml", fixed related junit tests. Thanks to Ryan's help on this! This addresses bug shindig-1592. https://issues.apache.org/jira/browse/shindig-1592 Diffs /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372 /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372 /trunk/content/sampledata/canonicaldb.json 1160372 /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372 Diff: https://reviews.apache.org/r/1616/diff Testing ------- Passed JUnit tests. Tested with /embeddedexperiences/index.html Thanks, li
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/1616/#review1620
        -----------------------------------------------------------

        Ship it!

        Committed revision 1161323. Please close the JIRA as well. Thanks.

        • Ryan

        On 2011-08-24 20:14:29, li xu wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/1616/

        -----------------------------------------------------------

        (Updated 2011-08-24 20:14:29)

        Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter.

        Summary

        -------

        This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080

        we added two tokens at sample db: canonicaldb.json

        %contextroot%

        %origin%

        it's resolved by JsonDBOpensocialService.java based on injected hostProvider

        This is a generic change... any other opensocial object could use the same token in sample json db.

        Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml

        "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml",

        fixed related junit tests.

        Thanks to Ryan's help on this!

        This addresses bug shindig-1592.

        https://issues.apache.org/jira/browse/shindig-1592

        Diffs

        -----

        /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372

        /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372

        /trunk/content/sampledata/canonicaldb.json 1160372

        /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372

        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372

        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372

        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372

        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372

        /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372

        Diff: https://reviews.apache.org/r/1616/diff

        Testing

        -------

        Passed JUnit tests.

        Tested with /embeddedexperiences/index.html

        Thanks,

        li

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/#review1620 ----------------------------------------------------------- Ship it! Committed revision 1161323. Please close the JIRA as well. Thanks. Ryan On 2011-08-24 20:14:29, li xu wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1616/ ----------------------------------------------------------- (Updated 2011-08-24 20:14:29) Review request for shindig, Paul Lindner, Henry Saputra, and Ryan Baxter. Summary ------- This fix enables EE sample page to work out of box even if it's deployed with a context root other than root or port other than 8080 we added two tokens at sample db: canonicaldb.json %contextroot% %origin% it's resolved by JsonDBOpensocialService.java based on injected hostProvider This is a generic change... any other opensocial object could use the same token in sample json db. Opensocial sample context is updated to include an additional attribute since photogadget.xml need to refer to AlbumViewer.xml "eeGadget" : "%origin%%contextroot%/samplecontainer/examples/embeddedexperiences/AlbumViewer.xml", fixed related junit tests. Thanks to Ryan's help on this! This addresses bug shindig-1592. https://issues.apache.org/jira/browse/shindig-1592 Diffs ----- /trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml 1160372 /trunk/content/samplecontainer/examples/embeddedexperiences/index.html 1160372 /trunk/content/sampledata/canonicaldb.json 1160372 /trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryAtomIds.xml 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonId.json 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonIds.json 1160372 /trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryXmlIds.xml 1160372 Diff: https://reviews.apache.org/r/1616/diff Testing ------- Passed JUnit tests. Tested with /embeddedexperiences/index.html Thanks, li
        Hide
        li xu added a comment -

        resolve the issue as it's committed by Ryan.

        Show
        li xu added a comment - resolve the issue as it's committed by Ryan.

          People

          • Assignee:
            Unassigned
            Reporter:
            li xu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development