Shindig
  1. Shindig
  2. SHINDIG-1581

When default-forced-libs and externalize-feature-libs, feature resources are duplicated.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0.2
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Java
    • Labels:
      None

      Description

      For network performance we choose to set externalize-feature-libs to true to lower ifr response sizes. On the other hand we also have some default-forced-libs.

      We have discovered that in this case the external script tag inserted two times one for the default-forced-libs, other for the gadget features. With JS servlet being unaware of there are two separate requests, the transitive dependencies included twice, as a result of this, some of the core libraries included twice.

      This behavior can be tested with setting externalize-feature-libs to true on default java server and running sample-pubsub-2.html from browser.

      The correct implementation should combine the two library requests into one to avoid double-load.

      1. SHINDIG-1581.patch
        3 kB
        Hasan Ceylan
      2. SHINDIG-1581-trunk.patch
        5 kB
        Hasan Ceylan

        Activity

        Hide
        Henry Saputra added a comment -

        Ah ok, so its a different issue =)

        Please send any info you saw to dev@shindig list. We should be able to help you.

        Show
        Henry Saputra added a comment - Ah ok, so its a different issue =) Please send any info you saw to dev@shindig list. We should be able to help you.
        Hide
        Hasan Ceylan added a comment -

        What I am saying is that, regardless of my patch, I cannot run the sample gadgets.

        Show
        Hasan Ceylan added a comment - What I am saying is that, regardless of my patch, I cannot run the sample gadgets.
        Hide
        Henry Saputra added a comment -

        Actually this should be resolved with new JS serving pipeline in 3.0.0

        Show
        Henry Saputra added a comment - Actually this should be resolved with new JS serving pipeline in 3.0.0
        Hide
        Henry Saputra added a comment -

        I am not sure I understand your last comment. Were you saying with the patch, running sample gadgets wont work?

        Show
        Henry Saputra added a comment - I am not sure I understand your last comment. Were you saying with the patch, running sample gadgets wont work?
        Hide
        Hasan Ceylan added a comment -

        Dear Henry,

        As stated before, I cannot get the samples to work. Having said that, I tried to test as best as I can by checking the scripts sent to browser in both externalize-feature-libs is true / false cases.

        As a side note, I noticed that the jsUrl in shindig.properties set to "//%host%/....", note the missing http(s) part. Although I am sure there is a reason for that, currently this is amongst the guilty parts the samples do not work.

        As I use git I create the patches from it. I tried to remove the header, if it still doesn't work, you may need to mangle the header a bit manually (another bug this time for eclipse egit team? )

        Thanks again for your interest in the issue.

        Regards,
        Hasan Ceylan

        Show
        Hasan Ceylan added a comment - Dear Henry, As stated before, I cannot get the samples to work. Having said that, I tried to test as best as I can by checking the scripts sent to browser in both externalize-feature-libs is true / false cases. As a side note, I noticed that the jsUrl in shindig.properties set to "//%host%/....", note the missing http(s) part. Although I am sure there is a reason for that, currently this is amongst the guilty parts the samples do not work. As I use git I create the patches from it. I tried to remove the header, if it still doesn't work, you may need to mangle the header a bit manually (another bug this time for eclipse egit team? ) Thanks again for your interest in the issue. Regards, Hasan Ceylan
        Hide
        Hasan Ceylan added a comment -

        A complete different implementation against trunk.

        Show
        Hasan Ceylan added a comment - A complete different implementation against trunk.
        Hide
        Henry Saputra added a comment -

        HI Hasan,

        Really appreciate the help. Please do provide patch if you can. Its still an issue in trunk AFAIK.

        • Henry
        Show
        Henry Saputra added a comment - HI Hasan, Really appreciate the help. Please do provide patch if you can. Its still an issue in trunk AFAIK. Henry
        Hide
        Hasan Ceylan added a comment -

        Hello Henry,

        First of all I appreciate the prompt handling of the bug I have submitted.

        I see that I lot of stuff has changed 3.0 development.

        As for your request, unless I am making a terrible mistake, almost none of the samples (which include rpc as this reflects the bug best) work when I switch to trunk.

        Based on your advise, I will be happy to provide a patch for the trunk?

        Best Regards,
        Hasan Ceylan

        Show
        Hasan Ceylan added a comment - Hello Henry, First of all I appreciate the prompt handling of the bug I have submitted. I see that I lot of stuff has changed 3.0 development. As for your request, unless I am making a terrible mistake, almost none of the samples (which include rpc as this reflects the bug best) work when I switch to trunk. Based on your advise, I will be happy to provide a patch for the trunk? Best Regards, Hasan Ceylan
        Hide
        Henry Saputra added a comment -

        HI Hasan, Could you create the patch without the header info and from Shindig trunk?

        I am having problem applying the patch.

        Show
        Henry Saputra added a comment - HI Hasan, Could you create the patch without the header info and from Shindig trunk? I am having problem applying the patch.
        Hide
        Hasan Ceylan added a comment -

        Proposed fix for the issue

        Show
        Hasan Ceylan added a comment - Proposed fix for the issue

          People

          • Assignee:
            Unassigned
            Reporter:
            Hasan Ceylan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development