Shindig
  1. Shindig
  2. SHINDIG-1559

Trailer comma in features/opensearch/opensearch.js

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.0.3
    • Fix Version/s: 2.0.3
    • Component/s: Javascript
    • Labels:

      Description

      trailing comma in the js file that would cause an error in IE

      1. osclosure.txt
        0.6 kB
        Igor Belakovskiy
      2. osclosure.txt
        0.6 kB
        Igor Belakovskiy

        Activity

        Gavin made changes -
        Workflow jira [ 12621351 ] patch-available, re-open possible [ 12630050 ]
        Hide
        Eric Woods added a comment -

        Nevermind. There is a unit test below that is uncommented for testing, making the comma necessary. Patch applied, thanks Igor.

        Show
        Eric Woods added a comment - Nevermind. There is a unit test below that is uncommented for testing, making the comma necessary. Patch applied, thanks Igor.
        Igor Belakovskiy made changes -
        Attachment osclosure.txt [ 12487448 ]
        Hide
        Igor Belakovskiy added a comment -

        Updated patch with Eric's suggestion

        Show
        Igor Belakovskiy added a comment - Updated patch with Eric's suggestion
        Hide
        Igor Belakovskiy added a comment -

        good point, adding updated patch.

        Show
        Igor Belakovskiy added a comment - good point, adding updated patch.
        Hide
        Eric Woods added a comment -

        Igor - why comment the comma out and not simply remove it? Seems we'd want to remove unused or unnecessary code to keep things clean.

        Show
        Eric Woods added a comment - Igor - why comment the comma out and not simply remove it? Seems we'd want to remove unused or unnecessary code to keep things clean.
        Igor Belakovskiy made changes -
        Field Original Value New Value
        Attachment osclosure.txt [ 12487444 ]
        Hide
        Igor Belakovskiy added a comment -

        patch for the fix.

        Show
        Igor Belakovskiy added a comment - patch for the fix.
        Igor Belakovskiy created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Igor Belakovskiy
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development