Shindig
  1. Shindig
  2. SHINDIG-1533

Common Container doesn't properly initialize globals when dynamically loaded

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Javascript
    • Labels:

      Description

      The container feature's init.js#initializeGlobalVars() function fails to properly initialize the global variables when the container.js is being dynamically loaded into a page.

      The code as it exists today assumes that the <script> tag loading the container.js will be the last one encountered for the document. This is not always the case, especially when loading the container.js by dynamically inserting the <script> tag in the page.

      Code changes and more information: http://codereview.appspot.com/4439090/

        Activity

        Paul Lindner made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.
        Gavin made changes -
        Workflow jira [ 12612875 ] patch-available, re-open possible [ 12630012 ]
        Stanton Sievers made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Show
        Stanton Sievers added a comment - http://svn.apache.org/viewvc?view=revision&revision=1103960
        Stanton Sievers created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Stanton Sievers
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 4h
              4h
              Remaining:
              Remaining Estimate - 4h
              4h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development