Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.5.0-beta1
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Java, Javascript
    • Labels:

      Description

      Shindig is running on ROOT only today. This patch enables Shindig to run on dynamic context root path without any hardcoded modification to the code.
      Test Case:
      1. deploy shindig.war with a context root path eg "test"
      2. test common container with this url:
      http://localhost:8080/test/samplecontainer/examples/commoncontainer/index.jsp

      Thanks Mark Nesbitt for the original idea of the patch.

        Activity

        Hide
        Henry Saputra added a comment -

        Would you mind uploading your patch to http://codereview.appspot.com/ for code review?

        You can add dev-remailer@shindig.apache.org as reviewer.

        Thanks.

        Show
        Henry Saputra added a comment - Would you mind uploading your patch to http://codereview.appspot.com/ for code review? You can add dev-remailer@shindig.apache.org as reviewer. Thanks.
        Hide
        li xu added a comment -

        yes, it's uploaded here: http://codereview.appspot.com/4430047/
        thanks.

        Show
        li xu added a comment - yes, it's uploaded here: http://codereview.appspot.com/4430047/ thanks.
        Hide
        Henry Saputra added a comment -

        Upload new CR to fix the Shindig svn base:

        http://codereview.appspot.com/4423064/

        Show
        Henry Saputra added a comment - Upload new CR to fix the Shindig svn base: http://codereview.appspot.com/4423064/
        Hide
        li xu added a comment -

        Patch is updated based on comments, please review
        http://codereview.appspot.com/4430047/

        Show
        li xu added a comment - Patch is updated based on comments, please review http://codereview.appspot.com/4430047/
        Hide
        li xu added a comment -

        A new patch is uploaded. Please review.
        It has been a while, please help move forward. thanks.

        List of things addressed with the patch...
        1. support context path other than root
        related updates to common container
        related updates to shindig container
        2. addressed all the comments received so far
        3. test passed

        Show
        li xu added a comment - A new patch is uploaded. Please review. It has been a while, please help move forward. thanks. List of things addressed with the patch... 1. support context path other than root related updates to common container related updates to shindig container 2. addressed all the comments received so far 3. test passed
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            li xu
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 336h
              336h
              Remaining:
              Remaining Estimate - 336h
              336h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development