Patch for View level features/locales

Updated patch to fix some code formatting.

Patch code review on appspot.

http://codereview.appspot.com/4077043/

Any ideas about these test failures when I apply this patch?

Tests in error:
unsupportedFeatureThrows(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest): Unexpected exception, expected<org.apache.shindig.gadgets.rewrite.RewritingException> but was<java.lang.AssertionError>
unsupportedViewFeatureThrows(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest): Unexpected exception, expected<org.apache.shindig.gadgets.rewrite.RewritingException> but was<java.lang.AssertionError>

Caused by: java.lang.AssertionError:
Unexpected method call getFeatureResources(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@4ded4d06, [core, foo], []):
getFeatureResources(same(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@4ded4d06), [foo, core], []): expected: 1, actual: 0
at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:45)
at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:73)
at org.easymock.internal.ClassProxyFactory$MockMethodInterceptor.intercept(ClassProxyFactory

Caused by: java.lang.AssertionError:
Unexpected method call getFeatureResources(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@770fba26, [core, foo], []):
getFeatureResources(same(org.apache.shindig.gadgets.render.RenderingGadgetRewriterTest$MapGadgetContext@770fba26), [foo, core], []): expected: 1, actual: 0
at org.easymock.internal.MockInvocationHandler.invoke(MockInvocationHandler.java:45)
at org.easymock.internal.ObjectMethodsFilter.invoke(ObjectMethodsFilter.java:73)
at org.easymock.internal.ClassProxyFactory$MockMethodInterceptor.intercept(ClassProxyFactory.java:92)
at org.apache.shindig.gadgets.features.FeatureRegistry$$EnhancerByCGLIB$$f7357840.getFeatureResources(<generated>)

Unfortunately no, all the test pass in my environment. Those "getFeatureResources" calls are setup in the expectFeatureCalls method of that test.

Are you taking the latest patch set from the code review tool or the one from here? The one attached here is old. I'll update it just in case.

Latest patch from http://codereview.appspot.com/4077043/

still failing for me on mac and linux, jdk 1.6 I think you just need to adjust your mocks for some other code that changed underneath you..

I've made some changes, tests now pass on IBM and Sun 1.6 JREs.

patch applied. Thanks!

part of 2.5.0-beta1 release.