Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1466

make gadget.util a singleton which will not impact the iframe rendering

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Major
    • Resolution: Unresolved
    • None
    • None
    • Javascript
    • None

    Description

      registerOnLoadHandler and runOnLoadHandlers: this two functions used an array "onLoadHandlers" to store and read the registered handlers and this is a locally variable. When rendering in iframe, the outside util and inside util are isolated, all theirs registered handler will be run. But when rendering inline, the inside util will rewrite the outside util due to the context merge issue described above, so the outside util's registered handler will not be run.

      if make gadgets.util, there is only one gadgets.util, and iframe rendering can't be effected, as it still will create one in the gadget.

      Attachments

        Activity

          People

            Unassigned Unassigned
            qiaoysun sun qiao yun
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: