Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.5.0-beta1
    • Component/s: Javascript
    • Labels:
      None

      Description

      To prevent the bogus behavior of caching request responses for 1 hour, we are setting REFRESH_INTERVAL to 0. But shindig and iGoogle seem to be ignoring values less than 1:

      code from io.js:

      if (httpMethod === "GET" && refreshInterval > 0) {

      1. zeroRefresh.txt
        1 kB
        Brian Lillie

        Activity

        Randy Hudson created issue -
        Randy Hudson made changes -
        Field Original Value New Value
        Component/s Javascript [ 12312114 ]
        Gavin made changes -
        Workflow jira [ 12524653 ] patch-available, re-open possible [ 12629745 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3773/
        -----------------------------------------------------------

        (Updated 2012-03-01 19:23:15.003539)

        Review request for Jesse Ciancetta and Stanton Sievers.

        Summary
        -------

        If a gadget does a makeRequest with method GET and REFRESH_INTERVAL = 0, the request is issued from the browser as a POST with no refresh interval, and results in the default caching interval used on the server. The POST prevents the browser caching, but the refresh interval also should be set to prevent the server caching, which I believe is the intended behavior.

        This addresses bug SHINDIG-1450.
        https://issues.apache.org/jira/browse/SHINDIG-1450

        Diffs


        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241007
        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1241475

        Diff: https://reviews.apache.org/r/3773/diff

        Testing
        -------

        Modified iotest.js and rest are passing

        Thanks,

        BrianLillie

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3773/ ----------------------------------------------------------- (Updated 2012-03-01 19:23:15.003539) Review request for Jesse Ciancetta and Stanton Sievers. Summary ------- If a gadget does a makeRequest with method GET and REFRESH_INTERVAL = 0, the request is issued from the browser as a POST with no refresh interval, and results in the default caching interval used on the server. The POST prevents the browser caching, but the refresh interval also should be set to prevent the server caching, which I believe is the intended behavior. This addresses bug SHINDIG-1450 . https://issues.apache.org/jira/browse/SHINDIG-1450 Diffs http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241007 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1241475 Diff: https://reviews.apache.org/r/3773/diff Testing ------- Modified iotest.js and rest are passing Thanks, BrianLillie
        Brian Lillie made changes -
        Attachment zeroRefresh.txt [ 12516716 ]
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3773/#review5513
        -----------------------------------------------------------

        Please always add SHindig as group for reviews. We would like to have open reviews for all Shindig community to participate.

        • Henry

        On 2012-03-01 19:23:15, BrianLillie wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3773/

        -----------------------------------------------------------

        (Updated 2012-03-01 19:23:15)

        Review request for Jesse Ciancetta and Stanton Sievers.

        Summary

        -------

        If a gadget does a makeRequest with method GET and REFRESH_INTERVAL = 0, the request is issued from the browser as a POST with no refresh interval, and results in the default caching interval used on the server. The POST prevents the browser caching, but the refresh interval also should be set to prevent the server caching, which I believe is the intended behavior.

        This addresses bug SHINDIG-1450.

        https://issues.apache.org/jira/browse/SHINDIG-1450

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241007

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1241475

        Diff: https://reviews.apache.org/r/3773/diff

        Testing

        -------

        Modified iotest.js and rest are passing

        Thanks,

        BrianLillie

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3773/#review5513 ----------------------------------------------------------- Please always add SHindig as group for reviews. We would like to have open reviews for all Shindig community to participate. Henry On 2012-03-01 19:23:15, BrianLillie wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3773/ ----------------------------------------------------------- (Updated 2012-03-01 19:23:15) Review request for Jesse Ciancetta and Stanton Sievers. Summary ------- If a gadget does a makeRequest with method GET and REFRESH_INTERVAL = 0, the request is issued from the browser as a POST with no refresh interval, and results in the default caching interval used on the server. The POST prevents the browser caching, but the refresh interval also should be set to prevent the server caching, which I believe is the intended behavior. This addresses bug SHINDIG-1450 . https://issues.apache.org/jira/browse/SHINDIG-1450 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241007 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1241475 Diff: https://reviews.apache.org/r/3773/diff Testing ------- Modified iotest.js and rest are passing Thanks, BrianLillie
        Stanton Sievers committed 1295757 (2 files)
        Reviews: none

        SHINDIG-1450 | io argument REFRESH_INTERVAL=0 is ignored | Patch from Brian Lillie, thanks

        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/3773/#review5514
        -----------------------------------------------------------

        Ship it!

        Committed revision 1295757. Thanks Brian.

        • Stanton

        On 2012-03-01 19:23:15, BrianLillie wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/3773/

        -----------------------------------------------------------

        (Updated 2012-03-01 19:23:15)

        Review request for Jesse Ciancetta and Stanton Sievers.

        Summary

        -------

        If a gadget does a makeRequest with method GET and REFRESH_INTERVAL = 0, the request is issued from the browser as a POST with no refresh interval, and results in the default caching interval used on the server. The POST prevents the browser caching, but the refresh interval also should be set to prevent the server caching, which I believe is the intended behavior.

        This addresses bug SHINDIG-1450.

        https://issues.apache.org/jira/browse/SHINDIG-1450

        Diffs

        -----

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241007

        http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1241475

        Diff: https://reviews.apache.org/r/3773/diff

        Testing

        -------

        Modified iotest.js and rest are passing

        Thanks,

        BrianLillie

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3773/#review5514 ----------------------------------------------------------- Ship it! Committed revision 1295757. Thanks Brian. Stanton On 2012-03-01 19:23:15, BrianLillie wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3773/ ----------------------------------------------------------- (Updated 2012-03-01 19:23:15) Review request for Jesse Ciancetta and Stanton Sievers. Summary ------- If a gadget does a makeRequest with method GET and REFRESH_INTERVAL = 0, the request is issued from the browser as a POST with no refresh interval, and results in the default caching interval used on the server. The POST prevents the browser caching, but the refresh interval also should be set to prevent the server caching, which I believe is the intended behavior. This addresses bug SHINDIG-1450 . https://issues.apache.org/jira/browse/SHINDIG-1450 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js 1241007 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js 1241475 Diff: https://reviews.apache.org/r/3773/diff Testing ------- Modified iotest.js and rest are passing Thanks, BrianLillie
        Hide
        Stanton Sievers added a comment -

        Committed revision 1295757. Thanks Brian.

        Show
        Stanton Sievers added a comment - Committed revision 1295757. Thanks Brian.
        Stanton Sievers made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.5.0 [ 12315324 ]
        Resolution Fixed [ 1 ]
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.
        Paul Lindner made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Randy Hudson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development