Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.2, 2.5.0-beta1
    • Component/s: Javascript
    • Labels:
      None

      Description

      Shindig 2.0 doesn't fully support Album and MediaItem described in OpenSocial 0.9 specification.

      • incorrect fields' names in opensocial.Album
      • missing fields in opensocial.MediaItem
      • missing opensocial.DataRequest.MediaItemRequestFields
      • missing function: newCreateAlbumRequest, newUpdateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newUpdateMediaItemRequest, newFetchMediaItemsRequest
      1. shindig_album_mediaitem.patch
        20 kB
        Jakub Białek
      2. shindig_album_mediaitem_trunk.patch
        28 kB
        Jakub Białek
      3. shindig_album_mediaitem_trunk_v2.patch
        30 kB
        Jakub Białek

        Activity

        Hide
        Jakub Białek added a comment -

        This patch contains:

        • fixed opensocial.Album fields names
        • added fields to opensocial.MediaItem
        • added functions: newCreateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newFetchMediaItemsRequest

        This patch doesn't contain implementation of newUpdateAlbumRequest and newUpdateMediaItemRequest

        Show
        Jakub Białek added a comment - This patch contains: fixed opensocial.Album fields names added fields to opensocial.MediaItem added functions: newCreateAlbumRequest, newDeleteAlbumRequest, newFetchAlbumsRequest, newCreateMediaItemRequest, newFetchMediaItemsRequest This patch doesn't contain implementation of newUpdateAlbumRequest and newUpdateMediaItemRequest
        Hide
        Jakub Białek added a comment -

        Patch available for code review at http://codereview.appspot.com/2265043/

        Show
        Jakub Białek added a comment - Patch available for code review at http://codereview.appspot.com/2265043/
        Hide
        Henry Saputra added a comment -

        You are using wrong base URL for the code review.

        Instead of http://svn.apache.org/repos/asf/incubator/shindig/trunk/trunk/ it should be http://svn.apache.org/repos/asf/shindig/trunk

        Show
        Henry Saputra added a comment - You are using wrong base URL for the code review. Instead of http://svn.apache.org/repos/asf/incubator/shindig/trunk/trunk/ it should be http://svn.apache.org/repos/asf/shindig/trunk
        Hide
        Jakub Białek added a comment -
        Show
        Jakub Białek added a comment - I've changed base URL to http://svn.apache.org/repos/asf/shindig/trunk
        Hide
        Henry Saputra added a comment -

        Proposed fix for shindig-1429

        Show
        Henry Saputra added a comment - Proposed fix for shindig-1429
        Hide
        Jakub Białek added a comment -

        Previously attached patch shindig_album_mediaitem was created using Shindig 2.0.0: http://svn.apache.org/repos/asf/shindig/tags/shindig-project-2.0.0/ as a base code, also some files were missing.
        New patch shindig_album_mediaitem_trunk.patch was created using Shindig trunk and contains JsonAlbum.js and JsonMediaItem.js files.

        Patch available for code review at http://codereview.appspot.com/2265043/ as a patch set 2.

        Show
        Jakub Białek added a comment - Previously attached patch shindig_album_mediaitem was created using Shindig 2.0.0: http://svn.apache.org/repos/asf/shindig/tags/shindig-project-2.0.0/ as a base code, also some files were missing. New patch shindig_album_mediaitem_trunk.patch was created using Shindig trunk and contains JsonAlbum.js and JsonMediaItem.js files. Patch available for code review at http://codereview.appspot.com/2265043/ as a patch set 2.
        Hide
        Henry Saputra added a comment -

        Deleting my attachment patch since Jakub has uploaded updated one from trunk.

        Show
        Henry Saputra added a comment - Deleting my attachment patch since Jakub has uploaded updated one from trunk.
        Hide
        Jakub Białek added a comment -

        I've add opensocial.newAlbum method and modified taming.js

        Patch available for code review at http://codereview.appspot.com/2265043/ as a patch set 3.

        Show
        Jakub Białek added a comment - I've add opensocial.newAlbum method and modified taming.js Patch available for code review at http://codereview.appspot.com/2265043/ as a patch set 3.
        Hide
        Henry Saputra added a comment -

        Patch applied with svn commit: r1000605

        Show
        Henry Saputra added a comment - Patch applied with svn commit: r1000605
        Hide
        Paul Lindner added a comment -

        part of 2.5.0-beta1 release.

        Show
        Paul Lindner added a comment - part of 2.5.0-beta1 release.

          People

          • Assignee:
            Unassigned
            Reporter:
            Jakub Białek
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development