Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1415

Invalid container configuration property name is breaking OAuth 1.0a client support in Java Shindig

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0
    • Java, PHP
    • None

    Description

      In the Java Shindig implementation DefaultOAuthUriManager looks for a container configuration property called "gadgets.uri.oauth.callbackTemplate" which doesn't exist anywhere in the current codebase, however there is a property called "gadgets.oauthGadgetCallbackTemplate" in the default container.js file which is referenced in a few places by the PHP Shindig implementation. This patch renames the "gadgets.oauthGadgetCallbackTemplate" property to "gadgets.uri.oauth.callbackTemplate" (since the latter is more inline with the rest of the configuration property names) and updates the PHP usages accordingly. Note that I don't run PHP Shindig so I don't really have any way to test if anything broke on the PHP end.

      Attachments

        1. OAuth-1.0a.patch
          2 kB
          Jesse Ciancetta

        Activity

          People

            Unassigned Unassigned
            jcian Jesse Ciancetta
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: