Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1400

Move tabs and minimessage from JavaScript files to container.js configuration file

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-RC2
    • Javascript
    • None

    Description

      — - 2010-07-28 15:50:45.000000000 +0200
      +++ features/src/main/javascript/features/tabs/tabs.js 2010-07-28 15:03:15.000000000 +0200
      @@ -123,56 +123,13 @@
      this.mainContainer_ = this.createMainContainer_(opt_container);
      this.tabTable_ = this.createTabTable_();
      this.displayTabs(false);

      • gadgets.TabSet.addCSS_([
      • '.tablib_table {', - 'width: 100%;', - 'border-collapse: separate;', - 'border-spacing: 0px;', - 'empty-cells: show;', - 'font-size: 11px;', - 'text-align: center;', - '}

        ',

      • '.tablib_emptyTab {', - 'border-bottom: 1px solid #676767;', - 'padding: 0px 1px;', - '}

        ',

      • '.tablib_spacerTab {', - 'border-bottom: 1px solid #676767;', - 'padding: 0px 1px;', - 'width: 1px;', - '}

        ',

      • '.tablib_selected {', - 'padding: 2px;', - 'background-color: #ffffff;', - 'border: 1px solid #676767;', - 'border-bottom-width: 0px;', - 'color: #3366cc;', - 'font-weight: bold;', - 'width: 80px;', - 'cursor: default;', - '}

        ',

      • '.tablib_unselected {', - 'padding: 2px;', - 'background-color: #dddddd;', - 'border: 1px solid #aaaaaa;', - 'border-bottom-color: #676767;', - 'color: #000000;', - 'width: 80px;', - 'cursor: pointer;', - '}

        ',

      • '.tablib_navContainer {', - 'width: 10px;', - 'vertical-align: middle;', - '}

        ',

      • '.tablib_navContainer a:link, ',
      • '.tablib_navContainer a:visited, ',
      • '.tablib_navContainer a:hover {', - 'color: #3366aa;', - 'text-decoration: none;', - '}

        '

      • ].join(''));
        };

      +gadgets.config.register("tabset", {}, function (configuration)

      { + // Injects the default stylesheet for tabs + gadgets.TabSet.addCSS_( configuration.tabs.css.join('')); +}

      );
      +
      /**

      • Adds a new tab based on the name-value pairs specified in opt_params.
      • @param {string}

        tabName Label of the tab to create.

      — - 2010-07-28 15:46:58.000000000 +0200
      +++ features/src/main/javascript/features/minimessage/minimessage.js 2010-07-28 15:08:56.000000000 +0200
      @@ -210,22 +210,10 @@
      };

      // Injects the default stylesheet for mini-messages.
      -gadgets.MiniMessage.addCSS_([

      • '.mmlib_table {', - 'width: 100%;', - 'font: bold 9px arial,sans-serif;', - 'background-color: #fff4c2;', - 'border-collapse: separate;', - 'border-spacing: 0px;', - 'padding: 1px 0px;', - '}

        ',

      • '.mmlib_xlink {', - 'font: normal 1.1em arial,sans-serif;', - 'font-weight: bold;', - 'color: #0000cc;', - 'cursor: pointer;', - '}

        '
        -].join(''));
        +gadgets.config.register("minimessage", {}, function (configuration)

        { + // Injects the default stylesheet for mini-messages + gadgets.MiniMessage.addCSS_( configuration.minimessage.css.join('')); +}

        );

      // Alias for legacy code

      — - 2010-07-28 15:23:39.000000000 +0200
      +++ config/container.js 2010-07-28 15:10:38.000000000 +0200
      @@ -149,6 +149,74 @@
      "aliases" : ["FULL_PAGE"]
      }
      },
      + "tabs" : {
      + "css": [
      + ".tablib_table

      {", + "width: 100%;", + "border-collapse: separate;", + "border-spacing: 0px;", + "empty-cells: show;", + "font-size: 11px;", + "text-align: center;", + "}

      ",
      + ".tablib_emptyTab

      {", + "border-bottom: 1px solid #676767;", + "padding: 0px 1px;", + "}

      ",
      + ".tablib_spacerTab

      {", + "border-bottom: 1px solid #676767;", + "padding: 0px 1px;", + "width: 1px;", + "}

      ",
      + ".tablib_selected

      {", + "padding: 2px;", + "background-color: #ffffff;", + "border: 1px solid #676767;", + "border-bottom-width: 0px;", + "color: #3366cc;", + "font-weight: bold;", + "width: 80px;", + "cursor: default;", + "}

      ",
      + ".tablib_unselected

      {", + "padding: 2px;", + "background-color: #dddddd;", + "border: 1px solid #aaaaaa;", + "border-bottom-color: #676767;", + "color: #000000;", + "width: 80px;", + "cursor: pointer;", + "}

      ",
      + ".tablib_navContainer

      {", + "width: 10px;", + "vertical-align: middle;", + "}

      ",
      + ".tablib_navContainer a:link, ",
      + ".tablib_navContainer a:visited, ",
      + ".tablib_navContainer a:hover

      {", + "color: #3366aa;", + "text-decoration: none;", + "}

      "
      + ]
      + },
      + "minimessage" : {
      + "css" : [
      + ".mmlib_table

      {", + "width: 100%;", + "font: bold 9px arial,sans-serif;", + "background-color: #fff4c2;", + "border-collapse: separate;", + "border-spacing: 0px;", + "padding: 1px 0px;", + "}

      ",
      + ".mmlib_xlink

      {", + "font: normal 1.1em arial,sans-serif;", + "font-weight: bold;", + "color: #0000cc;", + "cursor: pointer;", + "}

      "
      + ]
      + },
      "rpc" : {
      // Path to the relay file. Automatically appended to the parent
      // parameter if it passes input validation and is not null.

      Attachments

        Activity

          People

            Unassigned Unassigned
            bhofmann Bastian Hofmann
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment