[SHINDIG-1394] Gadget SigningFetcher creates invalid oauth_signature

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0-RC2
• Component/s: PHP
• Assignee: Unassigned
• Reporter: Bastian Hofmann
• Created: 21/Jul/10 16:16
• Updated: 26/Jul/10 05:37
• Resolved: 26/Jul/10 05:37

Description

If there are any query parameters in the request the current implementation of the SigningFetcher just concats

key=param&

for each parameter to the base string which results in one & too much at the end of the base string.

Fix:

Index: php/src/gadgets/SigningFetcher.php
===================================================================
139c139
< $newQuery = '';
—
> $newQueryParts = array();
143c143
< $newQuery .= urlencode($key) . '=' . urlencode($param) . '&';
—
> $newQueryParts[] = urlencode($key) . '=' . urlencode($param);
146c146
< $newQuery .= urlencode($key) . '=' . urlencode($elem) . '&';
—
> $newQueryParts[] = urlencode($key) . '=' . urlencode($elem);
150a151,153
>
> $newQuery = implode('&', $newQueryParts);
>