Shindig
  1. Shindig
  2. SHINDIG-1359

Increase visibility of selected fields in org.apache.shindig.gadgets.oauth.OAuthRequest to make subclassing easier

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0-RC2
    • Component/s: Java
    • Labels:
      None

      Description

      We are subclassing OAuthRequest and override its sanitizeAndSign method, which references "accessorInfo", which currently has "private" scope in the superclass.

      This is forcing us to redefine and initialize "accessorInfo" in our subclass, by copying this code from OAuthRequest#fetchNoThrow():

      accessorInfo = fetcherConfig.getTokenStore().getOAuthAccessor(
      realRequest.getSecurityToken(), realRequest.getOAuthArguments(), clientState,
      responseParams, fetcherConfig);

      As a result of this, we also need to redefine "realRequest" in our subclass, because it also has "private" scope in the superclass.

      We might consider broadening the scope of some of the other fields of OAuthRequest, but at a minimum, we should change the visibility of "accessorInfo" and "realRequest" from "private" to "protected".

        Activity

        Jan Luehe created issue -
        Paul Lindner made changes -
        Field Original Value New Value
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 2.0.0-RC1 [ 12314413 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow jira [ 12512890 ] patch-available, re-open possible [ 12629867 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Jan Luehe
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development