Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1359

Increase visibility of selected fields in org.apache.shindig.gadgets.oauth.OAuthRequest to make subclassing easier

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0.0-RC2
    • Java
    • None

    Description

      We are subclassing OAuthRequest and override its sanitizeAndSign method, which references "accessorInfo", which currently has "private" scope in the superclass.

      This is forcing us to redefine and initialize "accessorInfo" in our subclass, by copying this code from OAuthRequest#fetchNoThrow():

      accessorInfo = fetcherConfig.getTokenStore().getOAuthAccessor(
      realRequest.getSecurityToken(), realRequest.getOAuthArguments(), clientState,
      responseParams, fetcherConfig);

      As a result of this, we also need to redefine "realRequest" in our subclass, because it also has "private" scope in the superclass.

      We might consider broadening the scope of some of the other fields of OAuthRequest, but at a minimum, we should change the visibility of "accessorInfo" and "realRequest" from "private" to "protected".

      Attachments

        Activity

          People

            Unassigned Unassigned
            jluehe Jan Luehe
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: