Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1339

Change the modifier of the static member variables for BasicImageRewriter from public to private since they dont need to be public.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.0.0
    • 2.0.0-RC2
    • Java
    • None

    Description

      Change the public modifier for static variables in BasicImageRewriter that exposes UriCommon.Param enums as private since they serve no purpose other than used in the unit test.

      Change CONTENT_TYPE_AND_EXTENSION_MISMATCH and CONTENT_TYPE_AND_MIME_MISMATCH as package private for easy access from the unit test.

      Updated the unit test to reflect this.

      Code review at
      http://codereview.appspot.com/1211045/show

      Attachments

        1. pub_to_priv.patch
          5 kB
          Henry Saputra

        Activity

          People

            Unassigned Unassigned
            hsaputra Henry Saputra
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: