Shindig
  1. Shindig
  2. SHINDIG-1257

Allow extensions to JsonRpcHandler, plus bug fixes

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Critical Critical
    • Resolution: Fixed
    • Affects Version/s: 1.1-BETA5
    • Fix Version/s: 2.0.0-RC2
    • Component/s: Java
    • Labels:
      None

      Description

      Bug fix: altered the loop from a do/while to a simple while. Turns out, if there are no gadgets being requested, the do/while goes into an infinite wait, as "take()" will never return. A possible DOS attack vector, simply use up all the servlet processing threads. For this reason, I set the priority to Critical.

      Allow extensions to modify (generally add) metadata as part of JsonRpcHandler.Job, by Guicing JsonRpcHandler and extending Job.

      Enhancement: views may have attributes, they are now returned as part of the view metadata.

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        5d 1m 1 Paul Lindner 11/Jan/10 19:28
        Gavin made changes -
        Workflow jira [ 12486184 ] patch-available, re-open possible [ 12629606 ]
        Paul Lindner made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.1-BETA6 [ 12314413 ]
        Resolution Fixed [ 1 ]
        Hide
        Paul Lindner added a comment -

        lgtm

        Show
        Paul Lindner added a comment - lgtm
        Jon Weygandt made changes -
        Field Original Value New Value
        Attachment 100106-JsonRpc.patch [ 12429566 ]
        Hide
        Jon Weygandt added a comment -
        Show
        Jon Weygandt added a comment - Code review at: http://codereview.appspot.com/183130
        Jon Weygandt created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Jon Weygandt
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development