Uploaded image for project: 'Shindig'
  1. Shindig
  2. SHINDIG-1257

Allow extensions to JsonRpcHandler, plus bug fixes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 1.1-BETA5
    • 2.0.0-RC2
    • Java
    • None

    Description

      Bug fix: altered the loop from a do/while to a simple while. Turns out, if there are no gadgets being requested, the do/while goes into an infinite wait, as "take()" will never return. A possible DOS attack vector, simply use up all the servlet processing threads. For this reason, I set the priority to Critical.

      Allow extensions to modify (generally add) metadata as part of JsonRpcHandler.Job, by Guicing JsonRpcHandler and extending Job.

      Enhancement: views may have attributes, they are now returned as part of the view metadata.

      Attachments

        1. 100106-JsonRpc.patch
          5 kB
          Jon Weygandt

        Activity

          People

            Unassigned Unassigned
            jon.weygandt Jon Weygandt
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: