Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.1-BETA5
    • Component/s: Javascript
    • Labels:
      None

      Description

      At shindig/javascript/container/gadgets.js:639 in the handleSaveUserPrefs it makes this check:

      if (input.type != 'hidden')

      I think this should actually be:

      if (input.type == 'hidden')

      cause at the moment it actually skips all the relevant fields which results in prefs being empty and thus not getting saved.

      1. test.html
        1 kB
        Benjamin McCann

        Activity

        Christiaan Hees created issue -
        Hide
        Paul Lindner added a comment -
        Show
        Paul Lindner added a comment - Validated with http://widgets.nytimes.com/packages/html/igoogle/topstories.xml Thanks!
        Paul Lindner made changes -
        Field Original Value New Value
        Resolution Fixed [ 1 ]
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.1-BETA4 [ 12314249 ]
        Hide
        Benjamin McCann added a comment -

        This change needs to be reverted. The inputs generated by the prefs dialog script are not hidden as demonstrated by the attached file. You do not want to skip all non-hidden fields.

        Show
        Benjamin McCann added a comment - This change needs to be reverted. The inputs generated by the prefs dialog script are not hidden as demonstrated by the attached file. You do not want to skip all non-hidden fields.
        Benjamin McCann made changes -
        Attachment test.html [ 12422338 ]
        Hide
        Paul Lindner added a comment -

        will take a closer look at this. Thanks.

        Show
        Paul Lindner added a comment - will take a closer look at this. Thanks.
        Paul Lindner made changes -
        Resolution Fixed [ 1 ]
        Status Resolved [ 5 ] Reopened [ 4 ]
        Assignee Paul Lindner [ plindner ]
        Hide
        Benjamin McCann added a comment -

        I found out why the if block was causing trouble for the original bug reporter. It's because the prefs dialog updates hidden inputs when you check/uncheck a boolean preference. Text fields are non-hidden, so reversing the if statement isn't the right fix. We should instead remove the if statement.

        Show
        Benjamin McCann added a comment - I found out why the if block was causing trouble for the original bug reporter. It's because the prefs dialog updates hidden inputs when you check/uncheck a boolean preference. Text fields are non-hidden, so reversing the if statement isn't the right fix. We should instead remove the if statement.
        Paul Lindner made changes -
        Fix Version/s 1.1-BETA4 [ 12314249 ]
        Hide
        Paul Lindner added a comment -

        okay, resolved this by removing the if statement.

        Show
        Paul Lindner added a comment - okay, resolved this by removing the if statement.
        Paul Lindner made changes -
        Status Reopened [ 4 ] Resolved [ 5 ]
        Fix Version/s 1.1-BETA5 [ 12314355 ]
        Resolution Fixed [ 1 ]
        Gavin made changes -
        Workflow jira [ 12479408 ] patch-available, re-open possible [ 12629559 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Resolved Resolved
        16h 1 Paul Lindner 15/Oct/09 01:20
        Resolved Resolved Reopened Reopened
        5d 21h 52m 1 Paul Lindner 20/Oct/09 23:12
        Reopened Reopened Resolved Resolved
        26d 23h 52m 1 Paul Lindner 16/Nov/09 22:05

          People

          • Assignee:
            Paul Lindner
            Reporter:
            Christiaan Hees
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5m
              5m
              Remaining:
              Remaining Estimate - 5m
              5m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development