Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-967

Use the Maven Dependency Plugin to download artifacts for the Sqoop tests

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.0.0
    • Component/s: Test
    • Labels:
      None

      Description

      Currently the Maven antrun plugin is used to download a copy of Tomcat (6) and the Sqoop server to a "thirdparty" directory in the "sentry-tests/sentry-tests-sqoop" directory.

      However there are a number of problems with this approach:

      a) You are not downloading to a temporary directory (I guess to save having to download the artifacts on every build). This is not good practice, as a "mvn clean" doesn't actually clean this directory
      b) If the download is corrupted, the corrupted artifact will stay in "thirdparty", as the directory is not removed as part of the build process.
      c) The antrun/bash approach means that bash must be installed on the machine, which might be problematic (e.g. on windows)

      A better approach is to use the Maven dependency plugin to download the artifacts and copy them to a directory in the "target" directory of the tests. The artifacts get downloaded to the local maven repository, so after the first download, the build won't have to redownload anything. It should work on every platform as well.

        Attachments

        1. SENTRY-967.patch
          5 kB
          Colm O hEigeartaigh
        2. SENTRY-967-002.patch
          8 kB
          Brian Towles
        3. SENTRY-967-003.patch
          7 kB
          Brian Towles

          Issue Links

            Activity

              People

              • Assignee:
                btowles Brian Towles
                Reporter:
                coheigea Colm O hEigeartaigh
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: