Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-904

Set max message size for thrift messages

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.3.0
    • 1.7.0
    • None
    • None

    Description

      THRIFT-2572 can cause a service crash. Size of message can be out of range for two reasons: 1. Security scans 2. Malformatted message.

      We can fix this by using max message size configuration provided by TBinaryProtocol like how Hive handled it here

      And we should add a test to make sure scans are not bringing down the Sentry service.

      Example test:
      curl http://$(hostname -f):8038

      Attachments

        1. SENTRY-904-0.patch
          13 kB
          Li Li
        2. SENTRY-904-1.patch
          24 kB
          Li Li

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. SENTRY-909 Make max message size in ThriftSerializer configurable

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. SENTRY-910 Ideal max message size

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          links to

          Web Link review board

          Activity

            People

              lili Li Li
              sravya Sravya Tirukkovalur
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: