Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-904

Set max message size for thrift messages

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.3.0
    • Fix Version/s: 1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      THRIFT-2572 can cause a service crash. Size of message can be out of range for two reasons: 1. Security scans 2. Malformatted message.

      We can fix this by using max message size configuration provided by TBinaryProtocol like how Hive handled it here

      And we should add a test to make sure scans are not bringing down the Sentry service.

      Example test:
      curl http://$(hostname -f):8038

        Attachments

        1. SENTRY-904-1.patch
          24 kB
          Li Li
        2. SENTRY-904-0.patch
          13 kB
          Li Li

          Issue Links

            Activity

              People

              • Assignee:
                lili Li Li
                Reporter:
                sravya Sravya Tirukkovalur
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: