[SENTRY-777] SentryServiceIntegrationBase#after() should be run under client subject

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.6.0
• Assignee: Dapeng Sun
• Reporter: Dapeng Sun
• Created: 23/Jun/15 08:13
• Updated: 30/Jun/15 02:14
• Resolved: 30/Jun/15 02:13

Description

  @After
  public void after() throws Exception {
        if (client != null) {
          Set<TSentryRole> tRoles = client.listRoles(ADMIN_USER);
          if (tRoles != null) {
            for (TSentryRole tRole : tRoles) {
              client.dropRole(ADMIN_USER, tRole.getRoleName());
            }
          }
          client.close();
        }
        policyFilePath.delete();
  }

• client in after() isn't run under client subject, if client need client subject, such as in Kerberos mode, it may throw an exception.
• policyFilePath.delete(); may not execute if the client throws an exception when it does operations like clean db or close, there should be a try-catch-finally statement.

Issue Links

• links to: https://reviews.apache.org/r/35817/