[SENTRY-513] Sentry web service may not be stopped completely

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.5.0
• Fix Version/s: 1.5.0
• Assignee: Dapeng Sun
• Reporter: Dapeng Sun
• Created: 31/Oct/14 08:32
• Updated: 06/Nov/14 01:22
• Resolved: 05/Nov/14 21:16

Description

 public synchronized void stop() throws Exception{
    if (status == Status.NOT_STARTED) {
      return;
    }
    LOGGER.info("Attempting to stop...");

    if (thriftServer.isServing()) {
      thriftServer.stop(); // XXX If got exception here, the code after it will never be executed. 
    }
    thriftServer = null;
    stopSentryWebServer();
    status = Status.NOT_STARTED;
    LOGGER.info("Stopped...");
  }

if thriftServer got an exception when do stop, the method stopSentryWebServer() will be passed

Issue Links

• links to: Review board