Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-2151 Automatically derive owner privileges from Hive Object Ownership
  3. SENTRY-2280

The request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null

    XMLWordPrintableJSON

Details

    • Sub-task
    • Status: Resolved
    • Critical
    • Resolution: Fixed
    • 2.1.0
    • 2.1.0
    • Sentry
    • None

    Description

      When running e2e test TestDbPrivilegeCleanupOnDrop.testRenameTablesWithinDBSinglePrivilege, I found the request received in SentryPolicyStoreProcessor.sentry_notify_hms_event is null

      There are multiple issues in fix from "SENTRY-2243: Extend the thrift definition for policy service to learn owner information"

      1. The exception was thrown because the protocol_version was not set
      2. TSentryAuthorizable.server was not set
      3. TSentryHmsEventNotification.ownerType and ownerName are not set for table rename event

      As a result, the request received by server is null since thrift at server side cannot re-construct a valid request of type TSentryHmsEventNotification

      Once we fix the above issues, we need to make sure SentryPolicyStoreProcessor.sentry_notify_hms_event does not transfer owner in "alter table rename" event.

      Attachments

        1. SENTRY-2280.001.patch
          29 kB
          Na Li
        2. SENTRY-2280.002.patch
          40 kB
          Na Li
        3. SENTRY-2280.003.patch
          40 kB
          Na Li
        4. SENTRY-2280.004.patch
          41 kB
          Na Li
        5. SENTRY-2280.005.patch
          40 kB
          Na Li
        6. SENTRY-2280.006.patch
          40 kB
          Na Li
        7. SENTRY-2280.006.patch
          40 kB
          Na Li

        Issue Links

          Activity

            People

              linaataustin Na Li
              linaataustin Na Li
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: