[SENTRY-2184] Performance Issue: MPath is queried for each MAuthzPathsMapping in full snapshot

• Type: Bug
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.1.0
• Component/s: Sentry
• Assignee: Na Li
• Reporter: Na Li
• Created: 19/Mar/18 17:53
• Updated: 21/Mar/18 21:18
• Resolved: 21/Mar/18 21:18

Description

MAuthzPathsMapping contains list of MPath instances. From log message, when getting path full snapshot at SentryStore.retrieveFullPathsImageCore(), DataNucleus issues a query for all MPath instances associated with each MAuthzPathsMapping. Therefore, getting full path image may take a very long time.

The solution is to get MPath in a batch when getting full path image.

Log Message when DataNucleus issues a query for all MPath instances associated with each MAuthzPathsMapping

1) Initially, all MAuthzPathsMapping entries for current snapshot is queried.

2018-03-14 11:51:23,999 (main) [DEBUG - org.datanucleus.util.Log4JLogger.debug(Log4JLogger.java:58)] SELECT 'org.apache.sentry.provider.db.service.model.MAuthzPathsMapping' AS NUCLEUS_TYPE,A0.AUTHZ_OBJ_NAME,A0.AUTHZ_SNAPSHOT_ID,A0.CREATE_TIME_MS,A0.AUTHZ_OBJ_ID FROM AUTHZ_PATHS_MAPPING A0 WHERE A0.AUTHZ_SNAPSHOT_ID = <1>

2) call authzToPaths.getPathStrings() causes MPath to be queried for each AUTHZ_OBJ_ID

2018-03-14 11:52:27,700 (main) [DEBUG - org.datanucleus.util.Log4JLogger.debug(Log4JLogger.java:58)] SELECT 'org.apache.sentry.provider.db.service.model.MPath' AS NUCLEUS_TYPE,A0.PATH_NAME,A0.PATH_ID FROM AUTHZ_PATH A0 WHERE A0.AUTHZ_OBJ_ID = <1>

Issue Links

• links to: Review Link for this case