[SENTRY-2167] Change ignored logging messages to debug level in NotificationProcessor

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.1.0
• Fix Version/s: 2.1.0
• Component/s: Sentry
• Assignee: Krishna Kalyan
• Reporter: Krishna Kalyan
• Created: 08/Mar/18 14:40
• Updated: 19/Apr/18 14:30
• Resolved: 17/Apr/18 15:32

Description

Log levels of the couple of log messages looks to be in-correct. This has to be fixed.

Here is one of them

if ((oldDbName.equals(newDbName))
 && (oldTableName.equals(newTableName))
 && (oldLocation.equals(newLocation))) {
 LOGGER.error(String.format("Alter table notification ignored as neither name nor "
 + "location has changed: oldAuthzObj = %s, oldLocation = %s, newAuthzObj = %s, "
 + "newLocation = %s", oldDbName + "." + oldTableName, oldLocation,
 newDbName + "." + newTableName, newLocation));
 return false;
}

 

1. When the location and name of the object is not changed, sentry ignores that event. It is not an error. This should be logged with debug level.

2. When ever, SentryNoSuchObjectException is thrown, it is logged with INFO level. It is common that sentry doesn't have permissions on the objects that are changed. It need not be logged with INFO, instead it should be logged with debug level.