[SENTRY-2014] Incorrect handling of HDFS paths with multiple slashes

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Assignee: Vadim Spector
• Reporter: Vadim Spector
• Created: 20/Oct/17 22:51
• Updated: 20/Nov/17 21:16
• Resolved: 24/Oct/17 19:17

Description

To the best of my knowledge, there are at least three places in the code where HDFS paths may not be parsed correctly:

a) PathsUpdate.parsePath() does not handle collapse duplicate slashes in the path portion of URI into one slash. This method is used when getting paths data from HMS store. HDFS paths with duplicate slashes are perfectly legal and the specs refer to UNIX guidelines saying that multiple slashes should be treated as single slashes. If we keep multiple slashes in the path, such a path may be incorrectly split into path entries with some entries being empty, ultimately resulting in hard-to-troubleshoot ACL problems in the field. We should not assume that the URIs fed into parsePath() have already been normalized. It's easier to fix the code.

b) NotificationProcessor.splitPath() is using "/" regex instead of the correct "/+" one. While the inputs to this class may be controlled by Sentry software, which may normalize paths properly, it is better not to make such assumptions and just fix the code.

c) SentryStore.retrieveFullPathsImageCore() splits paths retrieved from database as "path.split("/") instead of path.split("/+")

This may result in hard-to-troubleshoot HDFS sync failures.

Issue Links

• links to: code review board