[SENTRY-2013] Align the SentryGenericServiceClient and SentryPolicyServiceClient a bit more closely

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.0.0
• Assignee: Colm O hEigeartaigh
• Reporter: Colm O hEigeartaigh
• Created: 20/Oct/17 16:16
• Updated: 25/Oct/17 11:22
• Resolved: 25/Oct/17 11:11

Description

The SentryPolicyServiceClient + SentryGenericServiceClient have a large number of shared methods, and a small number of methods with the same meaning but with slightly different names. This task is to align both clients so that the shared methods are called the same - this makes it a bit easier to read code when switching from generic to hive etc.

The proposed changes are:

SentryGenericServiceClient:

addRoleToGroups -> grantRoleToGroups
deleteRoleToGroups -> revokeRoleFromGroups
listPrivilegesByRoleName -> listAllPrivilegesByRoleName

SentryPolicyServiceClient:

listRoles -> listAllRoles

Issue Links

• links to: Review Request