Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-872 Uber jira for HMS HA + Sentry HA redesign
  3. SENTRY-1676

FullUpdateInitializer#createInitialUpdate should not throw RuntimeException

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 2.0.0
    • Component/s: Hdfs Plugin
    • Labels:
      None

      Description

      In FullUpdateInitialize#createInitialUpdate, it wraps any exception occurred in db tasks using RuntimeException

      FullUpdateInitialize.createInitialUpdate()
       // Fail the HMS startup if tasks are not all successful and
       // fail on partial updates flag is set in the config.
       if (!callResult.getSuccessStatus() && failOnRetry) {
          throw new RuntimeException(callResult.getFailure());
       }
      

      We should not use RumtimeException here, because it is an unchecked exception, which is easier to miss to catch from the callers.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                akolb Alex Kolbasov
                Reporter:
                eddyxu Lei (Eddy) Xu
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: