Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1625

PrivilegeOperatePersistence can use QueryParamBuilder

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.8.0, 2.0.0
    • Fix Version/s: 1.8.0, 2.0.0
    • Component/s: Sentry
    • Labels:
      None

      Description

      PrivilegeOperatePersistence has a few places where it builds queries using StringBuilder. It can benefit from the new QueryParamBuilder introduced in SentryStore.

      So I moved QueryParamBuilder to a separate class, moved a few methods from MSentryGMPrivilege to PrivilegeOperatePersistence (they were only used there) and converted all string-based query builders to QueryParamBuilder.

        Attachments

        1. SENTRY-1625.001-sentry-ha-redesign.patch
          58 kB
          Alexander Kolbasov
        2. SENTRY-1625.001.patch
          54 kB
          Alexander Kolbasov

          Issue Links

            Activity

              People

              • Assignee:
                akolb Alexander Kolbasov
                Reporter:
                akolb Alexander Kolbasov
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: