[SENTRY-1572] SentryMain() shouldn't dynamically load tool class

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.1.0
• Component/s: Sentry
• Labels: bite-sized newbie
• Assignee: Xinran Tinney
• Reporter: Alex Kolbasov
• Created: 16/Dec/16 23:20
• Updated: 22/Feb/18 02:49
• Resolved: 21/Feb/18 18:20

Description

TheSentryMain class currently works by mapping the command name to a Java class that is then dynamically loaded:

    String commandName = commandLine.getOptionValue(COMMAND);
    String commandClazz = COMMANDS.get(commandName);
    Object command;
    try {
      command = Class.forName(commandClazz.trim()).newInstance();
    } catch (Exception e) {
      String msg = "Could not create instance of " + commandClazz + " for command " + commandName;
      throw new IllegalStateException(msg, e);
    }
    if (!(command instanceof Command)) {
      String msg = "Command " + command.getClass().getName() + " is not an instance of "
          + Command.class.getName();
      throw new IllegalStateException(msg);
    }
    ((Command)command).run(commandLine.getArgs());
  }

This ia too complicated and causes subtle problems at runtime. Instead it should just create a new instance of appropriate class and call it directly.