Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-1557

getRolesForGroups() does too many trips to the the DB

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 1.8.0, 2.0.0
    • 1.8.0, 2.0.0
    • Sentry

    Description

      The function getRolesForGroups() does a SELECT query for each group in the input set. Instead it should do one of the following:

      1) A single SELECT with OR for all groups
      2) Just fetch all groups and filter in-memory.

      Attachments

        1. SENTRY-1557.patch
          2 kB
          Vamsee K. Yarlagadda
        2. SENTRY-1557.v2.patch
          5 kB
          Vamsee K. Yarlagadda
        3. SENTRY-1557.v3.patch
          7 kB
          Vamsee K. Yarlagadda

        Issue Links

          is cloned by

          Improvement - An improvement or enhancement to an existing feature or task. SENTRY-1561 Optimize the # of DB calls for the methods in SentryStore

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. SENTRY-1476 SentryStore is subject to JDQL injection

          • Major - Major loss of function.
          • Resolved
          links to

          Web Link Review board

          Activity

            People

              vamsee Vamsee K. Yarlagadda
              akolb Alex Kolbasov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: