Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1557

getRolesForGroups() does too many trips to the the DB

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.8.0, 2.0.0
    • Fix Version/s: 1.8.0, 2.0.0
    • Component/s: Sentry
    • Labels:

      Description

      The function getRolesForGroups() does a SELECT query for each group in the input set. Instead it should do one of the following:

      1) A single SELECT with OR for all groups
      2) Just fetch all groups and filter in-memory.

        Attachments

        1. SENTRY-1557.v3.patch
          7 kB
          Vamsee K. Yarlagadda
        2. SENTRY-1557.v2.patch
          5 kB
          Vamsee K. Yarlagadda
        3. SENTRY-1557.patch
          2 kB
          Vamsee K. Yarlagadda

          Issue Links

            Activity

              People

              • Assignee:
                vamsee Vamsee K. Yarlagadda
                Reporter:
                akolb Alex Kolbasov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: