Uploaded image for project: 'Sentry'
  1. Sentry
  2. SENTRY-1515

Cleanup exception handling in SentryStore

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.0
    • Fix Version/s: 1.8.0, 2.0.0
    • Component/s: Sentry
    • Labels:
      None

      Description

      The changes to SENTRY-1422 and SENTRY-1512 changed the semantics of several API calls:

      • hasAnyServerPrivileges
      • getMSentryPrivileges
      • getMSentryPrivilegesByAuth
      • getRoleNamesForGroups
      • retrieveFullPrivilegeImage
      • retrieveFullRoleImage
      • retrieveFullPathsImage
      • getAllRoleNames

      Previously they were not marked as throwing Exception, but they still could do it. With the change they now ignore exceptions and just log them which may not be the right thing to do.

      Instead they should be marked as throwing exceptions which has consequence for broader APIs which should be marked as well.

        Attachments

        1. SENTRY-1515.001.patch
          42 kB
          Alex Kolbasov

          Issue Links

            Activity

              People

              • Assignee:
                akolb Alex Kolbasov
                Reporter:
                akolb Alex Kolbasov
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: