[SENTRY-1491] Sentry transactions are not rolled back immediately when commit fails

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0, 2.0.0
• Fix Version/s: 1.8.0, 2.0.0
• Component/s: Sentry
• Assignee: Alex Kolbasov
• Reporter: Alex Kolbasov
• Created: 06/Oct/16 21:03
• Updated: 24/Jul/17 14:52
• Resolved: 03/Nov/16 07:56

Description

Here is the code for commitTransaction:

public void commitTransaction(PersistenceManager pm) {
  Transaction currentTransaction = pm.currentTransaction();
  try {
    Preconditions.checkState(currentTransaction.isActive(), "Transaction is not active");
    currentTransaction.commit();
  } finally {
    pm.close();
  }
}

so it does pm.close() in the finally clause, so it always closes pm.
Now everyone else does something like

  commitTransaction(pm);
  rollbackTransaction = false;
  return roles;
} finally {
  if (rollbackTransaction) {
    rollbackTransaction(pm);
  }
}

which means that pm is closed by the time we call rollbackTransaction() and we never rollback when commit fails. As a result rollback is deferred till connection close (which may be some time due to connection pooling) and we are potentially holding various locks for longer than needed.

Issue Links

• blocks: SENTRY-872 Uber jira for HMS HA + Sentry HA redesign
• is blocked by: SENTRY-1500 Sentry should use Datanucleus version of javax.jdo
• is blocked by: SENTRY-1501 SentryStore shouldn't synchronize openTransaction() and commitUpdateTransaction()
• relates to: SENTRY-1422 JDO deadlocks while processing grant while a background thread processes Notificationlogs