Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-1308

Generic Model is not consistent with role checking

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Open
    • Major
    • Resolution: Unresolved
    • 1.8.0
    • None
    • Service
    • None

    Description

      Roles are sometimes checked not in privilege commands:

      List: not checked
      Grant: checked
      Revoke: checked

      For consistency, I would argue they should always be checked. One counter argument could be that not checking is valid if an empty set of privileges are returned for list, but given you can't grant a privilege on a role that doesn't exist, this isn't interesting.

      Attachments

        1. SENTRY-1308.patch
          3 kB
          Gregory Chanan

        Activity

          People

            Unassigned Unassigned
            gchanan Gregory Chanan
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: