Uploaded image for project: 'Sentry (Retired)'
  1. Sentry (Retired)
  2. SENTRY-1267

Improve skipSlowAndNotThreadSafeTests blacklist/whitelist

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.8.0
    • Fix Version/s: None
    • Component/s: Test
    • Labels:
      None

      Description

      We currently explicitly exclude certain non thread safe tests:
      https://github.com/apache/sentry/blob/2109f42945cb132c4bf738649abf2935288d1e20/pom.xml#L897-L903

      Though it's nice that this list is in one place, this is unmaintainable as we add more tests. The usual way of solving this is to define annotations around the tests that define when they should run. E.g. in this case, there are a bunch of non-thread safe tests that derive from SentryGenericServiceIntegrationBase. We can just annotate this base class with @NonThreadSafe or something, which will be less of a maintenance headache.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                gchanan Gregory Chanan
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated: