[SEDONA-40] Pattern Match Wrong Ordering in GeometryCollectionSimplifier.scala

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 1.1.0
• Labels: pull-request-available
• Assignee: Jia Yu
• Reporter: Daniel Vetter
• Created: 01/Jun/21 14:59
• Updated: 09/Oct/21 22:00
• Resolved: 09/Oct/21 22:00

Description

Pattern matching in Scala happens in the order that matches are defined, meaning that in the GeometryCollectionSimplifier, the match will never land on the case collection: GeometryCollection. I might be missing something here, but figured I'd log this bug and find out. If it is wrong, then it can be fixed, and if it is right, then I can learn why. Thanks for the continued hard work on Sedona and really excited about ST_Subdivide!

https://github.com/apache/incubator-sedona/blob/55311f82b9a7c3ba6d215710c576134d1817edb6/sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/simplify/GeometryCollectionSimplifier.scala#L38

Issue Links

• links to: GitHub Pull Request #549