Uploaded image for project: 'Commons SCXML'
  1. Commons SCXML
  2. SCXML-279

Only use default Jexl3 setting for silent and strict, cleanup APIs accordingly

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.0
    • None

    Description

      SCXML-183 and SCXML-258 introduced and further extended upon custom configuration of the Jexl Engine for silent and strict mode.

      While at that time using strict=false as default seemed convenient (lenient), none of the (current) tests needs this, and neither can the w3c IRP tests pass using it.

      And, since the upgrade to Jexl3 (SCXML-254) these flags no longer can be dynamically changed in Jexl: these now are set as final when a Jexl Engine is created.

      With hindsight SCXML-258 really wasn't needed for adding a quite invasive API change while it only was/would be needed when using Jexl.

      Therefore I'll remove again the API change introduced by SCXML-258.
      And also drop the strict/silent flags (and getters) from the JexlEvaluator class, and just use the default Jexl Engine settings (silent=false, strict=true)

      Anyone needing a custom Jexl Engine configuration just can/should extend the JexlEvaluator class and override the createJexlEngine() method.
      Which already was required to customize other parts of the Jexl Engine anyway.

      Attachments

        Issue Links

          Activity

            People

              ate Ate Douma
              ate Ate Douma
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: