[SCM-916] Relative paths are not correctly inferred while creating the command line

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Incomplete
• Affects Version/s: 1.9.4
• Component/s: maven-scm-provider-gitexe
• Assignee: Unassigned
• Reporter: Carlo Marchiori
• Created: 21/Jan/19 12:10
• Updated: 03/Apr/19 20:03
• Resolved: 03/Apr/19 20:03

Description

Suppose you have the following situation

my-proj/pom.xml

my-proj-child1/pom.xml

my-proj-child2/pom.xml

with child my-proj-child1, my-proj-child2 maven modules of root project my-proj.

 

Farther suppose using the maven-release-plugin to build a multi-project release starting from my-proj project. The release plugin modifies poms and then tries to check them in. The working directory becomes my-proj and the file collection is 

[my-proj/pom.xml, my-proj-child1/pom.xml, my-proj-child2/pom.xml]

 

But while building the command line and removing the working directory from file paths, the class GitCommandLineUtils in the method addTarget transforms the file list in

[pom.xml, -child1/pom.xml, -child2/pom.xml]

which is wrong. The code should check if the prefix is a filesystem parent directory, not just a string prefix.

 

The problem gives rise to the following error

Caused by: org.apache.maven.shared.release.scm.ReleaseScmCommandException: Unable to commit files
Provider message:
The git-add command failed.
Command output:
fatal: pathspec '-child1\pom.xml' did not match any files