Uploaded image for project: 'Maven SCM'
  1. Maven SCM
  2. SCM-647

SvnChangeLogConsumer parses filename incorrectly when file is copied from existing one

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.5, 1.6
    • Fix Version/s: 1.6
    • Component/s: maven-scm-provider-svn
    • Labels:
      None
    • Flags:
      Patch

      Description

      Current implementations uses non-xml svn log for gathering information. It always returns everything after 5th char as the filename, which is a bug in cases like this:

      A /maven/scm/trunk/maven-scm-test/src/main/java/org/apache/maven/scm/ScmTestCase.java (from /maven/scm/trunk/maven-scm-api/src/main/java/org/apache/maven/scm/ScmTestCase.java:191665)

      which indicate copying a path from existing revision.

      Note that this example was taken from the svnlog2.txt line 510 file in test resources.

      I suggest to fix it with the attached patch. It also enhances tests to assert that the parsed filenames are correct - not containing spaces and beginning with common path.

        Attachments

        1. scm-svn-origfile.patch
          4 kB
          Petr Kozelka

          Activity

            People

            • Assignee:
              olamy Olivier Lamy
              Reporter:
              pkozelka Petr Kozelka
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: