[SCM-606] UnsupportedOperationException on blame GIT

• Type: Wish
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.4
• Fix Version/s: 1.5
• Component/s: maven-scm-provider-gitexe
• Flags: Patch
• Assignee: Mark Struberg
• Reporter: Fabien Bousquet
• Created: 10/Feb/11 12:02
• Updated: 05/Apr/15 14:54
• Resolved: 13/Feb/11 14:49

Description

Sometimes, running the blame command for GIT return an error for exit code. In this case, Maven SCM throw an
UnsupportedOperationException :

Caused by: java.lang.UnsupportedOperationException
at org.apache.maven.scm.provider.git.gitexe.command.blame.GitBlameCommand.executeBlameCommand(GitBlameCommand.java:46)
etc...

Is it possible to have the same way that others providers (SVN or TFS for example) which is to return a
result (with a success to false) ?

In other word replace :

  throw new UnsupportedOperationException();

by :

return new BlameScmResult(cl.toString(), "The git command failed.", stderr.getOutput(), false);

Another reason is that we do not know that this UnsupportedOperationException may be raised because is
a RuntimeException.

A similar problem : http://jira.codehaus.org/browse/SONARPLUGINS-618

Do you agree with that ?

Issue Links

• duplicates: SCM-532 Please add support for blame command